Skip to content

Disable schema verification#2300

Merged
djeebus merged 1 commit intomainfrom
disable-lint-verify
Apr 3, 2026
Merged

Disable schema verification#2300
djeebus merged 1 commit intomainfrom
disable-lint-verify

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented Apr 3, 2026

The server that hosts the schema is unreliable

the server that hosts the schema is unreliable
@djeebus djeebus marked this pull request as ready for review April 3, 2026 00:51
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 3, 2026

PR Summary

Low Risk
Low risk CI change that reduces flaky failures, but it may allow an invalid .golangci.yml schema to go unnoticed until lint execution.

Overview
Disables golangci-lint-action schema verification in the GitHub Actions lint workflow to avoid intermittent failures caused by timeouts fetching the remote JSON schema.

Written by Cursor Bugbot for commit 65c8a36. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — simple CI fix to suppress flaky schema-fetch timeouts.

Extended reasoning...

Overview

Single-line config change to .github/workflows/lint.yml: adds verify: 'false' to the golangci/golangci-lint-action@v8 step, disabling remote JSON schema validation that intermittently times out.

Security Risks

None. This is a CI/workflow-only change with no effect on production code. Disabling schema verification means a malformed .golangci.yml might not be caught at action startup, but any real misconfiguration would still surface as lint errors during execution.

Level of Scrutiny

Minimal scrutiny required. This is a purely mechanical CI reliability fix — one parameter added to a GitHub Actions step. The trade-off (slight reduction in config validation vs. elimination of flaky failures) is straightforward and well-documented in the comment.

Other Factors

No bugs were found. The change is self-contained, well-commented with the exact error message it addresses, and follows a common pattern for dealing with unreliable external schema servers.

@djeebus djeebus enabled auto-merge (squash) April 3, 2026 16:02
@djeebus djeebus merged commit 84584b0 into main Apr 3, 2026
39 of 40 checks passed
@djeebus djeebus deleted the disable-lint-verify branch April 3, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants