Skip to content

orchestrator: use block-sized memfile fetches behind a feature flag#2299

Closed
matthewlouisbrockman wants to merge 2 commits intomainfrom
memfile-block-sized-fetch
Closed

orchestrator: use block-sized memfile fetches behind a feature flag#2299
matthewlouisbrockman wants to merge 2 commits intomainfrom
memfile-block-sized-fetch

Conversation

@matthewlouisbrockman
Copy link
Copy Markdown
Contributor

@matthewlouisbrockman matthewlouisbrockman commented Apr 2, 2026

Cold resume on the memfile path could fetch 4 MiB even when the requested block size was smaller, such as 2 MiB. This change lets memfile fetches align with the actual block size, reducing over-fetching. Charts to follow but draft for sharing

nvm, results in less memory loaded but slower cause of gcs reads

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 2, 2026

PR Summary

Low Risk
Low risk because behavior changes are gated behind the new memfile-block-sized-fetch feature flag and only affect memfile reads; main risk is subtle cache/fetch boundary mismatches leading to unexpected read errors or performance regressions when enabled.

Overview
Adds an opt-in feature flag to make the non-streaming chunker fetch memfile data in blockSize increments instead of the fixed storage.MemoryChunkSize, by threading the storage object type into NewChunker and introducing a configurable fetchSize used throughout FullFetchChunker reads/writes.

Written by Cursor Bugbot for commit 164f747. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants