Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ReversibleTransformationInterface from TransformationInterface #8

Closed
gabesullice opened this issue Mar 8, 2018 · 2 comments
Closed

Extend ReversibleTransformationInterface from TransformationInterface #8

gabesullice opened this issue Mar 8, 2018 · 2 comments

Comments

@gabesullice
Copy link

shaper/src/DataAdaptor/ReversibleTransformationInterface.php

Line 7 in 84ba567

interface ReversibleTransformationInterface {

Right now, a ReversibleTransformationInterface only is one-way since it only has the undo method :P
@gabesullice gabesullice changed the title Shouldn't this extend from the TransformationInterface? Extend ReversibleTransformationInterface from TransformationInterface? Mar 8, 2018
@gabesullice gabesullice changed the title Extend ReversibleTransformationInterface from TransformationInterface? Extend ReversibleTransformationInterface from TransformationInterface Mar 8, 2018
@e0ipso
Copy link
Owner

e0ipso commented Mar 8, 2018

Honestly I can go either way. I'll be happy to merge a PR in that sense.

@e0ipso
Copy link
Owner

e0ipso commented May 19, 2021

This seems to have gotten stuck, feel free to request a re-open if you still want this to happen.

@e0ipso e0ipso closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e0ipso @gabesullice