-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate the possiblity to drop DataAdaptor #7
Comments
That's not correct. The validation is different at this point since we need to enforce common validation in the internal shape. |
I'm not saying the behavior needs to be dropped, I'm just saying to move the ReversibleTransformation |
Ugh, I'm sorry for all the noise. I'm clicking buttons on accident. |
@gabesullice I'm not 💯 sure I'm following your suggestion. Can you clarify a bit? Maybe a quick PR would be the simplest. |
I am gardening the issue queue a bit. If you still want this, let me know. |
I don't understand the remaining distinction between a transformation, reversible transformation and data adapter.
It seems like the DataAdaptor name could go away and just be a ReversibleTransformationBase that extends from TransformationBase
The text was updated successfully, but these errors were encountered: