Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the possiblity to drop DataAdaptor #7

Closed
gabesullice opened this issue Mar 8, 2018 · 5 comments
Closed

Evaluate the possiblity to drop DataAdaptor #7

gabesullice opened this issue Mar 8, 2018 · 5 comments

Comments

@gabesullice
Copy link

gabesullice commented Mar 8, 2018

I don't understand the remaining distinction between a transformation, reversible transformation and data adapter.

It seems like the DataAdaptor name could go away and just be a ReversibleTransformationBase that extends from TransformationBase

@e0ipso
Copy link
Owner

e0ipso commented Mar 8, 2018

That's not correct. The validation is different at this point since we need to enforce common validation in the internal shape.

@e0ipso e0ipso changed the title Need DataAdaptor? Evaluate the possiblity to drop DataAdaptor Mar 8, 2018
@gabesullice
Copy link
Author

I'm not saying the behavior needs to be dropped, I'm just saying to move the ReversibleTransformation

@gabesullice
Copy link
Author

Ugh, I'm sorry for all the noise. I'm clicking buttons on accident.

@gabesullice gabesullice reopened this Mar 8, 2018
@e0ipso
Copy link
Owner

e0ipso commented Jul 20, 2018

@gabesullice I'm not 💯 sure I'm following your suggestion. Can you clarify a bit? Maybe a quick PR would be the simplest.

@e0ipso
Copy link
Owner

e0ipso commented May 19, 2021

I am gardening the issue queue a bit. If you still want this, let me know.

@e0ipso e0ipso closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants