Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork sisyphus and maintain #2371

Open
hansegucker opened this issue Jan 13, 2025 · 4 comments · May be fixed by #2377
Open

Fork sisyphus and maintain #2371

hansegucker opened this issue Jan 13, 2025 · 4 comments · May be fixed by #2377
Labels
Discussion This issue requires some discussion and a decision what a solution might look like.

Comments

@hansegucker
Copy link
Collaborator

hansegucker commented Jan 13, 2025 •
edited
Loading

While implementing #1575, I discovered that sisyphus is broken and isn't maintained since seven years. As the source code is only 550 lines long and we could save some more lines by dropping unnecessary stuff, I would suggest to take the source code, drop the jQuery dependency and maintain it as .ts file in our source.
@hansegucker
Copy link
Collaborator Author

@richardebeling @niklasmohrin @Kakadus Would be great to get an opinion.

@richardebeling
Copy link
Member

Generally open to it, but I'm afraid without jquery it would be a bit more code -- if there's a way where we don't add more maintenance overhead, I'd prefer that :D

How is it broken -- anything we need to fix?

@niklasmohrin
Copy link
Member

I think it would be nice to have it in our repo for up to 200, maybe 300 lines of code. The original code has lengthy comments and support for some weird editor, I feel that it should be doable with modern browser APIs and typescript features in ~200 lines.

@janno42 janno42 added the Discussion This issue requires some discussion and a decision what a solution might look like. label Jan 20, 2025
@hansegucker
Copy link
Collaborator Author

How is it broken -- anything we need to fix?

It includes get parameters for URLs used as identifier for saved form data.

@hansegucker hansegucker linked a pull request Jan 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion This issue requires some discussion and a decision what a solution might look like.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Sisyphus to ts and drop unnecessary functionality hansegucker/EvaP
4 participants
@janno42 @richardebeling @hansegucker @niklasmohrin