Merge pull request #2042 from dyoshikawa/resolve-scrap-issue-1886-takt-permissions

dyoshikawa · web-flow · commit e51bb735530c · 2026-06-24T23:27:27.000+09:00
feat(takt): add mode-based permissions adapter
diff --git a/README.md b/README.md
@@ -95,7 +95,7 @@ The tables below show whether each tool supports a given feature (✅ = supporte
 | Kilo Code              |  ✅   |   ✅   | ✅  |    ✅    |    ✅     |   ✅   |  ✅   |     ✅      |
 | Roo Code               |  ✅   |   ✅   | ✅  |    ✅    |    ✅     |   ✅   |       |             |
 | Rovodev (Atlassian)    |  ✅   |        | ✅  |          |    ✅     |   ✅   |       |     ✅      |
-| Takt                   |  ✅   |        |     |    ✅    |    ✅     |   ✅   |       |             |
+| Takt                   |  ✅   |        |     |    ✅    |    ✅     |   ✅   |       |     ✅      |
 | Vibe Code              |  ✅   |   ✅   | ✅  |          |    ✅     |   ✅   |  ✅   |     ✅      |
 | Qwen Code              |  ✅   |   ✅   | ✅  |    ✅    |    ✅     |   ✅   |  ✅   |     ✅      |
 | Reasonix               |       |        | ✅  |          |           |        |       |             |
diff --git a/docs/reference/file-formats.md b/docs/reference/file-formats.md
@@ -883,4 +883,6 @@ For the Grok Build CLI (`grokcli`), this generates the `[ui] permission_mode` to
 
 For Vibe (mistral-vibe), this generates per-tool `[tools.<tool>]` tables in the shared `.vibe/config.toml` (project mode) or `~/.vibe/config.toml` (global mode). Tool-name mapping: `bash` → `bash`, `read` → `read_file`, `edit`/`write` → `write_file`, `webfetch` → `fetch`, `websearch` → `search_web`. Within a category, the catch-all `*` pattern sets the per-tool `permission` (`allow` → `always`, `ask` → `ask`) and also toggles the top-level `enabled_tools` / `disabled_tools` filters; specific patterns become **`allowlist` / `denylist`** entries — these are the keys Vibe's permission engine actually reads (`BaseToolConfig`), so the legacy `allow` / `deny` keys are dropped on generate (still honored as a fallback on import). Vibe has no per-pattern `ask`, so pattern-level `ask` rules are skipped with a warning. The `config.toml` file is shared with the MCP and hooks features, so writes merge non-destructively and the file is never deleted. See [mistral-vibe](https://github.com/mistralai/mistral-vibe) (`vibe/core/tools/base.py`).
 
+For Takt, this generates the `default_permission_mode` under `provider_profiles.<provider>` in the shared `.takt/config.yaml` (project mode) or `~/.takt/config.yaml` (global mode). Takt does not have per-tool / per-pattern rules; tool gating is a single coarse mode per provider profile, ordered `readonly` < `edit` < `full` (`readonly` may only read, `edit` may also edit/write files, `full` may also run shell commands). The active provider is named by the top-level `provider:` key (defaulting to `claude`). The mapping is therefore **lossy**: on generate, a single mode is derived with this precedence — (1) any `deny` rule anywhere ⇒ `readonly` (conservative — keep the narrowest mode whenever the user expressed any restriction); (2) else any `edit`/`write` category `allow` rule ⇒ `edit`; (3) else any `bash` category `allow` rule ⇒ `full`; (4) else ⇒ `readonly` (safe default). On import, `full` ⇄ `bash: { "*": "allow" }`, `edit` ⇄ `edit: { "*": "allow" }`, and `readonly` (or an unset/unknown mode) ⇄ `bash: { "*": "deny" }`. `config.yaml` is shared with other Takt settings, so the mode is merged in place — the active provider's other keys (e.g. `step_permission_overrides`), every other provider profile, and all other top-level keys are preserved — and the file is never deleted. See the [Takt configuration docs](https://github.com/nrslib/takt/blob/main/docs/configuration.md).
+
 > **Note: Interaction with ignore feature.** Both the ignore feature and the permissions feature can manage `Read` tool deny entries in `.claude/settings.json`. When both features configure the `Read` tool, the **permissions feature takes precedence** and a warning is emitted. If you only need to restrict file reads based on glob patterns, use the ignore feature (`.rulesync/.aiignore`). Use permissions only when you need fine-grained `allow`/`ask`/`deny` control over the `Read` tool.
diff --git a/docs/reference/supported-tools.md b/docs/reference/supported-tools.md
@@ -25,7 +25,7 @@ Rulesync supports both **generation** and **import** for All of the major AI cod
 | Kilo Code              | kilo            | ✅ 🌏 |   ✅   |  ✅ 🌏   |  ✅ 🌏   |   ✅ 🌏   | ✅ 🌏  | ✅ 🌏 |    ✅ 🌏    |
 | Roo Code               | roo             | ✅ 🌏 |   ✅   |    ✅    |    ✅    |    ✅     | ✅ 🌏  |       |             |
 | Rovodev (Atlassian)    | rovodev         | ✅ 🌏 |        |    🌏    |          |   ✅ 🌏   | ✅ 🌏  |       |     🌏      |
-| Takt                   | takt            | ✅ 🌏 |        |          |  ✅ 🌏   |   ✅ 🌏   | ✅ 🌏  |       |             |
+| Takt                   | takt            | ✅ 🌏 |        |          |  ✅ 🌏   |   ✅ 🌏   | ✅ 🌏  |       |    ✅ 🌏    |
 | Vibe Code              | vibe            | ✅ 🌏 |   ✅   |  ✅ 🌏   |          |   ✅ 🌏   | ✅ 🌏  | ✅ 🌏 |    ✅ 🌏    |
 | Qwen Code              | qwencode        | ✅ 🌏 |   ✅   | ✅ 🌏 🔧 |  ✅ 🌏   |   ✅ 🌏   | ✅ 🌏  | ✅ 🌏 |    ✅ 🌏    |
 | Reasonix               | reasonix        |       |        |  ✅ 🌏   |          |           |        |       |             |
diff --git a/skills/rulesync/file-formats.md b/skills/rulesync/file-formats.md
@@ -883,4 +883,6 @@ For the Grok Build CLI (`grokcli`), this generates the `[ui] permission_mode` to
 
 For Vibe (mistral-vibe), this generates per-tool `[tools.<tool>]` tables in the shared `.vibe/config.toml` (project mode) or `~/.vibe/config.toml` (global mode). Tool-name mapping: `bash` → `bash`, `read` → `read_file`, `edit`/`write` → `write_file`, `webfetch` → `fetch`, `websearch` → `search_web`. Within a category, the catch-all `*` pattern sets the per-tool `permission` (`allow` → `always`, `ask` → `ask`) and also toggles the top-level `enabled_tools` / `disabled_tools` filters; specific patterns become **`allowlist` / `denylist`** entries — these are the keys Vibe's permission engine actually reads (`BaseToolConfig`), so the legacy `allow` / `deny` keys are dropped on generate (still honored as a fallback on import). Vibe has no per-pattern `ask`, so pattern-level `ask` rules are skipped with a warning. The `config.toml` file is shared with the MCP and hooks features, so writes merge non-destructively and the file is never deleted. See [mistral-vibe](https://github.com/mistralai/mistral-vibe) (`vibe/core/tools/base.py`).
 
+For Takt, this generates the `default_permission_mode` under `provider_profiles.<provider>` in the shared `.takt/config.yaml` (project mode) or `~/.takt/config.yaml` (global mode). Takt does not have per-tool / per-pattern rules; tool gating is a single coarse mode per provider profile, ordered `readonly` < `edit` < `full` (`readonly` may only read, `edit` may also edit/write files, `full` may also run shell commands). The active provider is named by the top-level `provider:` key (defaulting to `claude`). The mapping is therefore **lossy**: on generate, a single mode is derived with this precedence — (1) any `deny` rule anywhere ⇒ `readonly` (conservative — keep the narrowest mode whenever the user expressed any restriction); (2) else any `edit`/`write` category `allow` rule ⇒ `edit`; (3) else any `bash` category `allow` rule ⇒ `full`; (4) else ⇒ `readonly` (safe default). On import, `full` ⇄ `bash: { "*": "allow" }`, `edit` ⇄ `edit: { "*": "allow" }`, and `readonly` (or an unset/unknown mode) ⇄ `bash: { "*": "deny" }`. `config.yaml` is shared with other Takt settings, so the mode is merged in place — the active provider's other keys (e.g. `step_permission_overrides`), every other provider profile, and all other top-level keys are preserved — and the file is never deleted. See the [Takt configuration docs](https://github.com/nrslib/takt/blob/main/docs/configuration.md).
+
 > **Note: Interaction with ignore feature.** Both the ignore feature and the permissions feature can manage `Read` tool deny entries in `.claude/settings.json`. When both features configure the `Read` tool, the **permissions feature takes precedence** and a warning is emitted. If you only need to restrict file reads based on glob patterns, use the ignore feature (`.rulesync/.aiignore`). Use permissions only when you need fine-grained `allow`/`ask`/`deny` control over the `Read` tool.
diff --git a/skills/rulesync/supported-tools.md b/skills/rulesync/supported-tools.md
@@ -25,7 +25,7 @@ Rulesync supports both **generation** and **import** for All of the major AI cod
 | Kilo Code              | kilo            | ✅ 🌏 |   ✅   |  ✅ 🌏   |  ✅ 🌏   |   ✅ 🌏   | ✅ 🌏  | ✅ 🌏 |    ✅ 🌏    |
 | Roo Code               | roo             | ✅ 🌏 |   ✅   |    ✅    |    ✅    |    ✅     | ✅ 🌏  |       |             |
 | Rovodev (Atlassian)    | rovodev         | ✅ 🌏 |        |    🌏    |          |   ✅ 🌏   | ✅ 🌏  |       |     🌏      |
-| Takt                   | takt            | ✅ 🌏 |        |          |  ✅ 🌏   |   ✅ 🌏   | ✅ 🌏  |       |             |
+| Takt                   | takt            | ✅ 🌏 |        |          |  ✅ 🌏   |   ✅ 🌏   | ✅ 🌏  |       |    ✅ 🌏    |
 | Vibe Code              | vibe            | ✅ 🌏 |   ✅   |  ✅ 🌏   |          |   ✅ 🌏   | ✅ 🌏  | ✅ 🌏 |    ✅ 🌏    |
 | Qwen Code              | qwencode        | ✅ 🌏 |   ✅   | ✅ 🌏 🔧 |  ✅ 🌏   |   ✅ 🌏   | ✅ 🌏  | ✅ 🌏 |    ✅ 🌏    |
 | Reasonix               | reasonix        |       |        |  ✅ 🌏   |          |           |        |       |             |
diff --git a/src/constants/takt-paths.ts b/src/constants/takt-paths.ts
@@ -9,3 +9,11 @@ export const TAKT_SKILLS_DIR_PATH = join(TAKT_FACETS_DIR_PATH, "knowledge");
 export const TAKT_SUBAGENTS_DIR_PATH = join(TAKT_FACETS_DIR_PATH, "personas");
 export const TAKT_OUTPUT_CONTRACTS_DIR_PATH = join(TAKT_FACETS_DIR_PATH, "output-contracts");
 export const TAKT_RULE_OVERVIEW_FILE_NAME = "overview.md";
+
+/**
+ * Takt's shared config file. Lives at `.takt/config.yaml` (project) and
+ * `~/.takt/config.yaml` (global); it holds the active provider, provider
+ * profiles (including permission modes), and other Takt settings.
+ * @see https://github.com/nrslib/takt/blob/main/docs/configuration.md
+ */
+export const TAKT_CONFIG_FILE_NAME = "config.yaml";
diff --git a/src/e2e/e2e-permissions.spec.ts b/src/e2e/e2e-permissions.spec.ts
@@ -471,6 +471,61 @@ describe("E2E: permissions", () => {
     expect(parsed.disabled_tools).toContain("write_file");
   });
 
+  it("should generate takt permissions into .takt/config.yaml", async () => {
+    const testDir = getTestDir();
+
+    // Pre-seed config.yaml with an active provider and unrelated keys to verify
+    // the non-destructive merge and that the mode is written under the active
+    // provider profile.
+    await writeFileContent(
+      join(testDir, ".takt", "config.yaml"),
+      ["provider: codex", "model: gpt-5", "provider_profiles:", "  codex: {}"].join("\n"),
+    );
+    await writeFileContent(
+      join(testDir, RULESYNC_PERMISSIONS_RELATIVE_FILE_PATH),
+      JSON.stringify(
+        {
+          permission: {
+            bash: { "*": "allow" },
+          },
+        },
+        null,
+        2,
+      ),
+    );
+
+    await runGenerate({ target: "takt", features: "permissions" });
+
+    const parsed = toTable(load(await readFileContent(join(testDir, ".takt", "config.yaml"))));
+    // Active provider preserved; only-bash allow collapses to the `full` mode.
+    expect(parsed.provider).toBe("codex");
+    expect(parsed.model).toBe("gpt-5");
+    const profiles = toTable(parsed.provider_profiles);
+    expect(toTable(profiles.codex).default_permission_mode).toBe("full");
+  });
+
+  it("should import takt permissions into .rulesync/permissions.json", async () => {
+    const testDir = getTestDir();
+
+    await writeFileContent(
+      join(testDir, ".takt", "config.yaml"),
+      [
+        "provider: claude",
+        "provider_profiles:",
+        "  claude:",
+        "    default_permission_mode: edit",
+      ].join("\n"),
+    );
+
+    await runImport({ target: "takt", features: "permissions" });
+
+    const content = JSON.parse(
+      await readFileContent(join(testDir, RULESYNC_PERMISSIONS_RELATIVE_FILE_PATH)),
+    );
+    // `edit` mode imports back to an `edit` allow catch-all.
+    expect(content.permission.edit["*"]).toBe("allow");
+  });
+
   it("should remove denied Kiro web tools from existing allowedTools", async () => {
     const testDir = getTestDir();
 
@@ -1507,6 +1562,47 @@ describe("E2E: permissions (global mode)", () => {
     expect(content).toContain("[mcp_servers.example]");
     expect(content).toContain('theme = "dark"');
   });
+
+  it("should generate takt permissions in home directory with --global", async () => {
+    const projectDir = getProjectDir();
+    const homeDir = getHomeDir();
+
+    await writeFileContent(
+      join(projectDir, RULESYNC_PERMISSIONS_RELATIVE_FILE_PATH),
+      JSON.stringify(
+        {
+          permission: {
+            bash: { "*": "allow", "rm *": "deny" },
+          },
+        },
+        null,
+        2,
+      ),
+    );
+
+    // Pre-seed config.yaml with unrelated user settings to verify the
+    // non-destructive merge into ~/.takt/config.yaml.
+    await writeFileContent(
+      join(homeDir, ".takt", "config.yaml"),
+      ["provider: claude", "model: claude-sonnet"].join("\n"),
+    );
+
+    await runGenerate({
+      target: "takt",
+      features: "permissions",
+      global: true,
+      env: { HOME_DIR: homeDir },
+    });
+
+    // Takt gates tools with the coarse `default_permission_mode` under
+    // `provider_profiles.<provider>` in the global ~/.takt/config.yaml. A `deny`
+    // rule collapses the lossy mapping to `readonly`.
+    const parsed = toTable(load(await readFileContent(join(homeDir, ".takt", "config.yaml"))));
+    const profiles = toTable(parsed.provider_profiles);
+    expect(toTable(profiles.claude).default_permission_mode).toBe("readonly");
+    // Unrelated user settings preserved by the non-destructive merge.
+    expect(parsed.model).toBe("claude-sonnet");
+  });
 });
 
 type AugmentEntry = {
diff --git a/src/features/permissions/permissions-processor.test.ts b/src/features/permissions/permissions-processor.test.ts
@@ -94,6 +94,7 @@ describe("PermissionsProcessor", () => {
         "kiro-ide",
         "opencode",
         "qwencode",
+        "takt",
         "vibe",
         "zed",
       ]);
@@ -116,6 +117,7 @@ describe("PermissionsProcessor", () => {
         "opencode",
         "qwencode",
         "rovodev",
+        "takt",
         "vibe",
         "warp",
         "zed",
@@ -140,6 +142,7 @@ describe("PermissionsProcessor", () => {
         "kiro-ide",
         "opencode",
         "qwencode",
+        "takt",
         "vibe",
         "zed",
       ]);
diff --git a/src/features/permissions/permissions-processor.ts b/src/features/permissions/permissions-processor.ts
@@ -26,6 +26,7 @@ import { OpencodePermissions } from "./opencode-permissions.js";
 import { QwencodePermissions } from "./qwencode-permissions.js";
 import { RovodevPermissions } from "./rovodev-permissions.js";
 import { RulesyncPermissions } from "./rulesync-permissions.js";
+import { TaktPermissions } from "./takt-permissions.js";
 import type {
   ToolPermissionsForDeletionParams,
   ToolPermissionsFromFileParams,
@@ -295,6 +296,21 @@ export const toolPermissionsFactories = new Map<
       },
     },
   ],
+  [
+    "takt",
+    {
+      class: TaktPermissions,
+      meta: {
+        // Takt gates tools with the coarse `default_permission_mode`
+        // (readonly < edit < full) under `provider_profiles.<provider>` in the
+        // shared config: `.takt/config.yaml` (project) and
+        // `~/.takt/config.yaml` (global).
+        supportsProject: true,
+        supportsGlobal: true,
+        supportsImport: true,
+      },
+    },
+  ],
   [
     "vibe",
     {
diff --git a/src/features/permissions/takt-permissions.test.ts b/src/features/permissions/takt-permissions.test.ts
diff --git a/src/features/permissions/takt-permissions.ts b/src/features/permissions/takt-permissions.ts
diff --git a/src/types/tool-target-tuples.ts b/src/types/tool-target-tuples.ts
