Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing fallback value for site_url? #116

Open
jfly opened this issue Nov 6, 2023 · 0 comments
Open

Consider removing fallback value for site_url? #116

jfly opened this issue Nov 6, 2023 · 0 comments

Comments

@jfly
Copy link

jfly commented Nov 6, 2023

I just spent a while trying to figure out why a gatsby generated rss feed included links to this repo. After much searching, I discovered this fallback code: https://github.com/dylang/node-rss/blob/1.2.2/lib/index.js#L36. This doesn't feel like a very sane default to me. (I don't think there is a sane default one could have here.)

The docs in readme.md (https://github.com/dylang/node-rss/tree/1.2.2#feedoptions) do not declare this as optional:

 * `site_url` **url string** Url to the site that the feed is for.
 * `image_url` _optional_  **url string** Small image for feed readers to use.

Could we instead throw an exception if site_url is not specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant