Stop returning `this` and return the actual created instance #22

jean9696 · 2022-06-20T21:32:12Z

jean9696
Jun 20, 2022

For now, the approach is to allow the chaining of functions calls like this:

dxf.setCurrentLayer('l_green')
    .addSpline(points, points, 3, 8, [], [])
    .setCurrentLayer('l_red')
    .addCircle(60, 150, 50)

This seems nice but with this approach we have no way to retrieve the created instance (circle for instance)

I think it would be intersting to switch to the following synthax:

    dxf.setCurrentLayer('l_green')
    dxf.addSpline(points, points, 3, 8, [], [])
    dxf.setCurrentLayer('l_red')
    const circle = dxf.addCircle(60, 150, 50)

It will be easier to test and edit properties.
Another approach would be to have different ways to create elements by duplicating the class functions addCircle would have drawCircle method that returns the Circle instance

public drawCircle(
		center: point3d_t,
		radius: number,
		startAngle: number,
		endAngle: number,
		options?: options_t
	): Circle {
		return DxfManager.getInstance().modelSpace.addArc(
			center,
			radius,
			startAngle,
			endAngle,
			options
		);
	}
public addCircle(...params) {
                this.drawCircle(...params)
                return this
        }