docs: Add PR feedback suggestions to future enhancements

[dwalleck]

Added 4 suggestions from PR #23 review to the Future Enhancements section:

High Priority:

• Unit tests for interactive mode (test cancellation, mocked inputs)

Medium Priority:

• Configuration profiles (save/load presets for skill selections)
• Dynamic separator width (terminal-aware UI sizing)
• Skill preview in interactive mode (press 'i' for details)
• Custom progress bar themes (via CATALYST_THEME env var)

These are deferred post-MVP enhancements that would improve UX and testability of the interactive mode implementation.

🤖 Generated with Claude Code

[claude]

PR Review: Documentation Enhancement

Summary

This PR adds 4 suggestions from PR #23 review to the Future Enhancements section of the catalyst-cli plan. The additions are well-organized by priority and include specific implementation examples.

---

✅ Strengths

1. Well-Organized Additions

   • Clear priority categorization (High vs Medium)
   • Each enhancement includes concrete code examples
   • Proper markdown formatting with code blocks

2. Actionable Specifications

   • Unit test example shows specific test case (test_user_cancels_at_directory_prompt)
   • Configuration profiles include CLI syntax examples
   • Dynamic separator width shows exact implementation approach

3. Preserves Document Structure

   • Maintains existing High/Medium/Low priority sections
   • Follows established formatting patterns
   • Properly integrates with surrounding content

---

📋 Code Quality

Documentation Standards: ✅ Excellent

• Code examples use proper Rust syntax
• Bash examples show realistic usage patterns
• Consistent indentation and formatting

Consistency: ✅ Good

• Follows existing bullet point style
• Uses same formatting for code blocks as rest of document
• Maintains established priority categorization

---

🔍 Detailed Analysis

High Priority Addition (Line 453-460)

#[test]
fn test_user_cancels_at_directory_prompt() {
    // Mock dialoguer to return false
    // Assert Ok(None) returned
}

Feedback:

• ✅ Excellent addition - unit tests for interactive mode are critical
• ✅ Specific test case name is descriptive
• 💡 Suggestion: Consider adding a note about the testing strategy:
  • How to mock dialoguer (might need mockall crate or dependency injection)
  • Expected test coverage percentage for interactive mode

Medium Priority Additions (Lines 467-484)

1. Configuration Profiles (Lines 467-471)

catalyst init --interactive --save-as my-preset
catalyst init --preset my-preset

• ✅ Clear CLI syntax examples
• ✅ Addresses common user workflow (save/reuse configs)
• 💡 Consider: Where would presets be stored? (~/.catalyst/presets/?)

2. Dynamic Separator Width (Lines 472-476)

// Instead of const SEPARATOR_WIDTH: usize = 60;
let separator_width = terminal_size().map(|(w, _)| w).unwrap_or(60);

• ✅ Shows exact implementation change
• ✅ Includes fallback value (60)
• ⚠️ Minor Issue: Missing crate reference - would need terminal_size crate

3. Skill Preview (Lines 477-480)

• ✅ Simple, clear interaction pattern
• 💡 Suggestion: Specify which library handles key press detection in interactive mode

4. Custom Progress Bar Themes (Lines 481-484)

• ✅ Environment variable naming follows conventions
• ✅ Example shows realistic usage

---

🎯 Recommendations

Required Changes: None

The PR is ready to merge as-is.

Optional Enhancements:

1. Add Implementation Notes (Medium Priority Items)

   - **Dynamic separator width** - Make terminal UI responsive to terminal width
     - Requires: `terminal_size` crate
     - Note: Ensure minimum width (e.g., 40) for narrow terminals

2. Cross-Reference Testing Strategy

   • Link unit test enhancement to Phase 8 (Testing) in the main plan
   • Add note about target test coverage for interactive mode (e.g., "Aim for 80%+ coverage")

3. Clarify Configuration Profile Storage

   # Stored at ~/.catalyst/presets/my-preset.toml
   catalyst init --interactive --save-as my-preset
   catalyst init --preset my-preset

---

📊 Impact Assessment

Scope: Documentation only - no code changes
Risk: None - additions are in Future Enhancements section
User Impact: Positive - captures valuable feedback for future development
Maintenance: Low - well-documented enhancements are easier to implement later

---

✅ Final Verdict

APPROVED ✅

This PR successfully captures and organizes feedback from PR #23 review into actionable future enhancements. The additions are well-thought-out, include concrete examples, and maintain document consistency.

Minor Suggestions Above Are Optional - The PR is production-ready as-is.

---

🏷️ Labels Recommendation

• documentation
• enhancement
• future-work

---

Review completed by Claude Code
Related: Based on PR #23 feedback
Document: dev/active/catalyst-cli/catalyst-cli-plan.md:453-484