Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Processing instructions for MegaDepth Option 1 are incomplete. #3

Open
SergioRAgostinho opened this issue Jul 12, 2023 · 0 comments

Comments

@SergioRAgostinho
Copy link
Collaborator

Just logging some problems I've discovered.

I've been going over the data preparation instructions for megadepth and noticed that Option 1 is not really an option.

gomatch/tools/README.md

Lines 25 to 31 in 3cd031d

#### Option 1
By default the tool assumes there is a folder with the undistorted SfM reconstruction of MegaDepth symlinked to the `data` folder, as explained in the previous section. If the folder is symlinked, theoretically no arguments need to passed. Just call the tool with
```
$ python tools/prep_megadepth_2D3D_data.py
```
After completion, the tool will generate a number of files in `data/MegaDepth_undistort/data_processed/v2`.

If you follow those instructions it will not generate the necessary file that is then required in the follow-up step

gomatch/tools/README.md

Lines 42 to 49 in 3cd031d

### Generating a Descriptor Cache
Run the tool `tools/extract_features_immatch.py`.
```
python -m tools.extract_features_immatch --immatch_config 'immatch/sift' --dataset 'megadepth'
```
This will generate the descriptor cache for sift.

Our config is looking for

data_file: "sift_pts/megadepth_2d3d_q500ov0.35tp3-10_imsz.irat1.5.sift1024.npy"

but our generation script would never be able to create that file
data_save_path = os.path.join(
save_dir,
f"megadepth_2d3d_q{args.scene_max}ov{args.overlap[0]}-{args.overlap[1]}covis{topk_min}-{topk_max}.npy",
)

the string irat is not even part of the file name construction.

So something got lost during the public release. I'll try to see if I figure out what exactly.

@SergioRAgostinho SergioRAgostinho changed the title Data Processing instruction for MegaDepth Option 1 are incomplete. Data Processing instructions for MegaDepth Option 1 are incomplete. Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant