Support for CM13

[habeIchVergessen]

not yet: FLAG_TURN_SCREEN_ON needs to be implemented

[bradhawkins85]

I just installed on SM-G900F running CM13 (20160114 Build) and can confirm it works for me

[habeIchVergessen]

can you post a debug output (incl. cover actions)?

[bradhawkins85]

I closed and opened the cover 5 times in this log.
Log_2016-01-16_21-28-18.txt

I am having a random issue with the screen coming on when the cover is closed and not turning back off. I will attach the log when I can get one.

[habeIchVergessen]

thx for logs. it seems not to be my fork of the project. can you post a link of used apk file?
accept/reject/hangup calls works?

[bradhawkins85]

Here's the link
https://github.com/durka/HallMonitor/blob/0.4.1/bin/HallMonitor-debug.apk?raw=true

Haven't tried calls yet, sorry, will let you know when I dodo.

Will give your fork a go tomorrow.

[bradhawkins85]

habeIchVergessen here is the log from your fork and a screenshot.

Log_2016-01-17_12-58-43.txt

Haven't had a chance to test the calls yet but none of the shortcuts work in either build but the other one does not have the display issues, also the battery percentage doesn't change in your build

[pressh]

I can take a log on sm-n910c cm13 if you want.

It doesn't work too reliable, if you close the lid very gently the s view doesn't kick in. Your fork maybe slightly less reliable than durka's apk and I may have a crash in your fork overnight but I didn't take a log.

As for the shortcuts, I need to do more testing but the issue is that high sensitivity for the screen (glove mode, not sure how it is actually called) is not activated. You can do it manually and then the shortcuts seem to sort of work (though sometimes Google now or something starts and that uses full screen). Not really a solution though as the glove mode gets deactivated when opening the lid again.

As for the camera, it gives me a tiny preview venster but the actual picture taking does not work (only tried on durka's apk).

I could silence an alarm with glove mode activated, haven't tested calls yet.

Guess biggest issue for now is the glove mode not getting activated (maybe I can do it with tasker?) and the actual picture taking not working.

Guess I need to mod it myself a bit for the larger s view venster on the note 4.

[habeIchVergessen]

debug my fork:

• press seven times About ("debug enabled" messages appears)
• do some cover actionsi
• check the sd-card option
• press seven times About ("debug disabled" message)
• new file should be written to Download

changing touch sensivity requires root privileges. do you checked the option?

the screenshots looks terrible. seems to be a general problem. the layout uses only the visible area under the cover. surrounding area is window background.

[pressh]

Yes root enabled but seems it doesn't kick in tot handel the screen sensitiviteit. It just worked for a minuten or so after I reinstalled tour fork but stoppen now.

I attached a regular logcat, debugging output is saved to a nog existing location I don't have /storage/sdcard0

Anyway, dit soms fast closes of the lid at which hallmonitor kicks in and a few slow ones where it doesn't. After that I manually enabled glove mode and pushed some of the buttons. Picture preview for camera shows up, taking a picture causes a crash according to the logcat. Also in camera preview mode the screen times out. On touchwiz camera preview keeps the screen awake so you have more time to take a picture. Maybe it is an idea to increase the screen time out when the camera is activated.

Let me know if I need to do more tests.

Cheers,
logcat.txt

[habeIchVergessen]

try to enable the glove mode manually

S4

• on: echo clear_cover_mode,1 > /sys/class/sec/tsp/cmd && cat /sys/class/sec/tsp/cmd_result
• off: echo clear_cover_mode,0 > /sys/class/sec/tsp/cmd && cat /sys/class/sec/tsp/cmd_result

S4 mini

• on:
  echo module_on_master > /sys/class/sec/tsp/cmd && cat /sys/class/sec/tsp/cmd_result ; echo clear_cover_mode,3 > /sys/class/sec/tsp/cmd && cat /sys/class/sec/tsp/cmd_result
• off:
  echo module_on_master > /sys/class/sec/tsp/cmd && cat /sys/class/sec/tsp/cmd_result ; echo clear_cover_mode,0 > /sys/class/sec/tsp/cmd && cat /sys/class/sec/tsp/cmd_result

[pressh]

The s4 commands seem to work on the note4 as well, although not 100% reliable. Somehow the camera also started to take pictures, albeit sideways (preview has correct orientation). Guess I'll need to take another logcat to find out why at is going on and why it sometimes works and sometimes causes a crash.

[B--B]

Seems that finally google provided a fix for this issue, please take a look here: AOSP-JF-MM/platform_frameworks_base@39d533c

This is a better solution than force FLAG_TURN_SCREEN_ON when the device tries to go to sleep

Can be simply enabled with an overlay in the device tree (see here: AOSP-JF-MM/platform_device_samsung_jflte@7b27428 )

Tested with my old Hallmonitor fork and it's working fine without any issue! Well, timeout does not work, and a lot of things must be updated but... It's working now! ;)

Ps: can be easily merged on cm-13.0 too, but the rom must be compiled with the different overlay

EDIT: This has been merged on AOSP master branch a few days ago: https://android.googlesource.com/platform/frameworks/base/+/7def60daa049271c0d595d2ff566965693ee88cd