Support Android 6 / version 23 #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 15, 2020 18:55
The logging tag can be at most 23 characters, was 29 The logging tag can be at most 23 characters, was 31
…tual JSON into this library (does not conform to standard though)
…e is also read from the JSON
…fAttestationObject or NoneAttestationObject
…fAttestationObject or NoneAttestationObject
… id and firefox also only checks > 64 (https://searchfox.org/mozilla-central/source/dom/webauthn/WebAuthnManager.cpp#267)
…ial.id was random id internal to the database, while userHandle is the id communicated with the server
…ses credential.userHandle to filter. Now checks for both on the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8, but also
Cherry pick commits as needed, #8 is fixed in commit 1eea292