Skip to content

Commit ae6dd08

Browse files
authored
Merge pull request #68 from Dudi119/Development
cppkin test will use now random port.
2 parents a3d4aee + 21676d8 commit ae6dd08

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

tests/server.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
from bottle import Bottle, ServerAdapter
22
from wsgiref.simple_server import make_server
3+
import socket
4+
from contextlib import closing
35

46
class WSGIRefServerStoppable(ServerAdapter):
57
def __init__(self, host, port, **options):
@@ -11,4 +13,10 @@ def run(self, handler):
1113
self._server.serve_forever()
1214

1315
def stop(self):
14-
self._server.shutdown()
16+
self._server.shutdown()
17+
18+
@staticmethod
19+
def findFreePort():
20+
with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as s:
21+
s.bind(('', 0))
22+
return s.getsockname()[1]

tests/tests.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from zipkinStubServer import ServerGuard, ZipkinStubServer
2+
from server import WSGIRefServerStoppable
23
import _cppkin
34
from _cppkin import Trace, CppkinParams
45
import unittest
@@ -42,9 +43,11 @@ def runTest(self):
4243
self.assertEqual(spans[0].parentId, spans[1].id, "Span parent id dosn't match trace's id {0} != {1}".format(spans[0].parentId, spans[1].id))
4344

4445
def main():
46+
port = WSGIRefServerStoppable.findFreePort()
47+
4548
params = CppkinParams()
4649
params.add_str(_cppkin.HOST_ADDRESS, "127.0.0.1")
47-
params.add_int(_cppkin.PORT, 9411)
50+
params.add_int(_cppkin.PORT, port)
4851
params.add_str(_cppkin.SERVICE_NAME, "cppkinTest")
4952
params.add_bool(_cppkin.DEBUG, True)
5053
params.add_str(_cppkin.TRANSPORT_TYPE, "Http Transport")
@@ -54,7 +57,7 @@ def main():
5457

5558
global outQueue
5659
global startEvent
57-
server = ZipkinStubServer()
60+
server = ZipkinStubServer(port)
5861
outQueue = Queue()
5962
startEvent = Event()
6063
with ServerGuard(ZipkinStubServer.spawn, server, outQueue, startEvent):

0 commit comments

Comments
 (0)