Skip to content

Commit 7ea8fea

Browse files
committed
Address ship review UI comments
1 parent 48e2084 commit 7ea8fea

File tree

8 files changed

+13
-8
lines changed

8 files changed

+13
-8
lines changed

special-pages/pages/new-tab/app/components/TickPill/TickPill.module.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
align-items: center;
44
gap: 6px;
55
padding: 8px 10px;
6-
border-radius: 100px;
6+
border-radius: 1000px;
77
background-color: var(--color-white-at-3);
88
border: 1px solid var(--color-white-at-12);
99
height: 20px;
@@ -32,8 +32,8 @@
3232

3333
/* Light mode styles */
3434
[data-theme="light"] .tickPill {
35-
background-color: var(--color-black-at-4);
36-
border: 1px solid var(--color-black-at-12);
35+
background-color: var(--color-black-at-1);
36+
border: 1px solid var(--color-black-at-9);
3737
}
3838

3939
[data-theme="light"] .text {

special-pages/pages/new-tab/app/privacy-stats/components/PrivacyStats.module.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
height: 16px;
4040
display: inline-block;
4141
vertical-align: middle;
42+
margin-top: 2px;
4243
}
4344

4445
.widgetExpander {

special-pages/pages/new-tab/app/protections/components/Protections.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
}
4545

4646
.block {
47-
margin-top: 32px;
47+
margin-top: 16px;
4848
}
4949

5050
/* @todo legacyProtections: Remove once all platforms support the new UI */

special-pages/pages/new-tab/app/protections/integrations-tests/protections.screenshots.spec.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ test.describe('Protections screenshots', { tag: ['@screenshots'] }, () => {
1010
const ntp = NewtabPage.create(page, workerInfo);
1111
await ntp.reducedMotion();
1212
const protections = new ProtectionsPage(ntp);
13-
await ntp.openPage({ additional: { 'protections.feed': 'privacy-stats' } });
13+
// Use cpm: 'true' to enable new UI (non-legacy)
14+
await ntp.openPage({ additional: { 'protections.feed': 'privacy-stats', cpm: 'true' } });
1415
await protections.ready();
1516

1617
await expect(protections.context()).toHaveScreenshot('protections-stats.png', { maxDiffPixels });
@@ -19,7 +20,8 @@ test.describe('Protections screenshots', { tag: ['@screenshots'] }, () => {
1920
const ntp = NewtabPage.create(page, workerInfo);
2021
await ntp.reducedMotion();
2122
const protections = new ProtectionsPage(ntp);
22-
await ntp.openPage({ additional: { 'protections.feed': 'privacy-stats', activity: 'empty' } });
23+
// Use cpm: 'true' to enable new UI (non-legacy)
24+
await ntp.openPage({ additional: { 'protections.feed': 'privacy-stats', activity: 'empty', cpm: 'true' } });
2325
await protections.ready();
2426
await expect(protections.context()).toHaveScreenshot('protections-stats-empty.png', { maxDiffPixels });
2527
});
@@ -28,7 +30,8 @@ test.describe('Protections screenshots', { tag: ['@screenshots'] }, () => {
2830
await ntp.reducedMotion();
2931
await ntp.darkMode();
3032
const protections = new ProtectionsPage(ntp);
31-
await ntp.openPage({ additional: { 'protections.feed': 'privacy-stats' } });
33+
// Use cpm: 'true' to enable new UI (non-legacy)
34+
await ntp.openPage({ additional: { 'protections.feed': 'privacy-stats', cpm: 'true' } });
3235
await protections.ready();
3336

3437
await expect(protections.context()).toHaveScreenshot('protections-stats-dark.png', { maxDiffPixels });
@@ -38,7 +41,8 @@ test.describe('Protections screenshots', { tag: ['@screenshots'] }, () => {
3841
const ntp = NewtabPage.create(page, workerInfo);
3942
await ntp.reducedMotion();
4043
const protections = new ProtectionsPage(ntp);
41-
await ntp.openPage({ additional: { 'protections.feed': 'activity' } });
44+
// Use cpm: 'null' to enable new UI (non-legacy) with feature disabled
45+
await ntp.openPage({ additional: { 'protections.feed': 'activity', cpm: 'null' } });
4246
await protections.ready();
4347

4448
await expect(protections.context()).toHaveScreenshot('protections-activity.png', { maxDiffPixels });
Loading
Loading
Loading
Loading

0 commit comments

Comments
 (0)