Skip to content

Conversation

@muodov
Copy link
Member

@muodov muodov commented Jul 21, 2025

@muodov muodov requested review from Copilot and sammacbeth July 21, 2025 09:34
@muodov muodov added minor Increment the minor version when merged release Create a release when this pr is merged labels Jul 21, 2025

This comment was marked as outdated.

Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing, the shadow dom-ed versions didn't work for me. I see the popup starting to hide, but then it comes back again. Maybe we're too fast?


async waitForPopup(cmp: AutoCMP, retries = 5, interval = 500): Promise<boolean> {
// TODO: use MutationObserver like in findCmp()
async waitForPopup(cmp: AutoCMP, retries = 10, interval = 500): Promise<boolean> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muodov did you mean to make this change?

generateCMPTests('axeptio', ['https://www.welcometothejungle.com/', 'https://frichti.co/landing?redirectTo=/', 'https://www.dorcel.com/']);
generateCMPTests('axeptio', [
'https://www.welcometothejungle.com/',
'https://frichti.co/landing?redirectTo=/',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing this site was using com_didomi.io.

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged release Create a release when this pr is merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants