-
Notifications
You must be signed in to change notification settings - Fork 26
Support shadowDOM version of axeptio #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
sammacbeth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In testing, the shadow dom-ed versions didn't work for me. I see the popup starting to hide, but then it comes back again. Maybe we're too fast?
|
|
||
| async waitForPopup(cmp: AutoCMP, retries = 5, interval = 500): Promise<boolean> { | ||
| // TODO: use MutationObserver like in findCmp() | ||
| async waitForPopup(cmp: AutoCMP, retries = 10, interval = 500): Promise<boolean> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muodov did you mean to make this change?
tests/axeptio.spec.ts
Outdated
| generateCMPTests('axeptio', ['https://www.welcometothejungle.com/', 'https://frichti.co/landing?redirectTo=/', 'https://www.dorcel.com/']); | ||
| generateCMPTests('axeptio', [ | ||
| 'https://www.welcometothejungle.com/', | ||
| 'https://frichti.co/landing?redirectTo=/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing this site was using com_didomi.io.
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
Task/Issue URL: https://app.asana.com/1/137249556945/project/1203268166580279/task/1210827498245648?focus=true
Description:
Supports a shadowdom flavor of axeptio
Steps to test this PR:
Test on these sites: