Report more errors to the background script and test runner #686
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
reviewed
Mar 10, 2025
Contributor
noisysocks
left a comment
noisysocks
left a comment
There was a problem hiding this comment.
Good idea. I made very similar changes to playwright/runner.ts locally when I was debugging issues.
Code looks good to me aside from question around whether it’s a good idea to have AutoConsent leak information about the messaging channel.
Could you please provide testing instructions?
| domActions: DomActions; | ||
| filtersEngine: FiltersEngine; | ||
| protected sendContentMessage: MessageSender; | ||
| sendContentMessage: MessageSender; |
Contributor
There was a problem hiding this comment.
Maybe _runRulesSequentially in AutoConsentCMP should throw an error that AutoConsent catches? We're mixing concerns somewhat by having AutoConsentCMP know about the messaging channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor tweak to make the test output more helpful