[iOS][Feature Flags] Remove SAD flag for active and inactive users (#2681)

Task/Issue URL: https://app.asana.com/1/137249556945/project/1206329551987282/task/1211866611125558?focus=true
Tech Design URL:
CC:

### Description

This PR removes two feature flags for SAD prompts:

**Active Users**
Commit:
60b2521
Feature Flag Task:
https://app.asana.com/1/137249556945/project/1206329551987282/task/1211866611125558?focus=true

 **Inactive Users**
Commit:
208a41a
Feature Flag Task:
https://app.asana.com/1/137249556945/project/1206329551987282/task/1211866470962985?focus=true

Even though we use remote settings for the two prompts to function, the
settings are defined in the parent feature, so it is safe to remove the
subfeature from the codebase.

### Testing Steps
1. Put a breakpoint in `DefaultBrowserPromptFeatureFlagger.swift` ->
`private func getSettings(_ value: DefaultBrowserPromptFeatureSettings)
-> Int` line 102.
2. Open Debug Menu -> 'Default Browser Prompt’ and follow the
instructions to make SAD prompt appear.
3. Ensure that
`settingsProvider.defaultBrowserPromptFeatureSettings[value.rawValue]
as? Int` returns a value and it’s not nil.

### Impact and Risks
<!— 
What's the impact on users if something goes wrong?

High: Could affect user privacy, lose user data, break core
functionality
Medium: Could disrupt specific features or user flows
Low: Minor visual changes, small bug fixes, improvement to existing
features
None: Internal tooling, documentation
—>

#### What could go wrong?
<!-- Describe specific scenarios and how you've addressed them —>

### Quality Considerations
<!— 
Focus on what matters for your changes:
- What edge cases exist?
- How does this affect performance?
- What monitoring have you added?
- What documentation needs updating?
- How does this impact privacy/security?
—>

### Notes to Reviewer
<!-- Anything specific you want reviewers to focus on —>

—
###### Internal references:
[Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f) |
[Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552) |
[Tech Design
Template](https://app.asana.com/0/59792373528535/184709971311943)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Removes active/inactive scheduled default browser prompt feature flags
and gating, simplifying to use privacy-config settings only and updating
factory, logic, and tests accordingly.
> 
> - **Feature flags/config**:
> - Remove iOS `FeatureFlag` cases `scheduledSetDefaultBrowserPrompts`
and `scheduledSetDefaultBrowserPromptsForInactiveUsers`, related
override/support lists, and source mappings in
`iOS/Core/FeatureFlag.swift`.
> - Remove iOS subfeatures from `SetAsDefaultAndAddToDockSubfeature` in
`PrivacyFeature.swift`.
> - **Default Browser Prompt (SAD) implementation**:
> - Simplify `DefaultBrowserPromptFeatureFlagAdapter` to only expose
`defaultBrowserPromptFeatureSettings` (no enablement booleans).
> - `DefaultBrowserPromptFactory` no longer accepts
`featureFlagProvider`; `DefaultBrowserPromptFeatureFlag` now constructed
with only `settingsProvider`.
> - Drop enablement checks in prompt deciders
(`DefaultBrowserPromptTypeDecider` active/inactive) and in
`DefaultBrowserPromptService.resume()`; always record activity.
> - Debug view: always shows settings and is enabled; remove
feature-enabled gating.
> - **SetDefaultBrowserCore**:
> - Delete active/inactive feature provider protocols; keep only
settings-driven `DefaultBrowserPromptFeatureFlagger` values.
> - **Tests**:
> - Remove tests/mocks for enablement booleans; update tests to use
settings-only paths and constructor changes.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
f04cf27. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: alessandroboron

SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift

@@ -467,12 +467,6 @@ public enum SetAsDefaultAndAddToDockSubfeature: String, PrivacySubfeature {
 
     // https://app.asana.com/1/137249556945/project/492600419927320/task/1210863200265479?focus=true
     case scheduledDefaultBrowserAndDockPromptsInactiveUser // macOS
-
-    // https://app.asana.com/1/137249556945/project/1206329551987282/task/1209304767941984?focus=true
-    case scheduledDefaultBrowserPrompts // iOS
-
-    // https://app.asana.com/1/137249556945/project/1206329551987282/task/1210716028790591?focus=true
-    case scheduledDefaultBrowserPromptsInactiveUser // iOS
 }
 
 public enum OnboardingSubfeature: String, PrivacySubfeature {

iOS/Core/FeatureFlag.swift

@@ -154,12 +154,6 @@ public enum FeatureFlag: String {
     /// https://app.asana.com/1/137249556945/project/1211834678943996/task/1211866463389447
     case showSettingsCompleteSetupSection
 
-    /// https://app.asana.com/1/137249556945/project/1211834678943996/task/1211866611125558
-    case scheduledSetDefaultBrowserPrompts
-
-    /// https://app.asana.com/1/137249556945/project/1211834678943996/task/1211866470962985
-    case scheduledSetDefaultBrowserPromptsForInactiveUsers
-
     /// https://app.asana.com/1/137249556945/project/1211834678943996/task/1211866607644644
     case canPromoteImportPasswordsInPasswordManagement
 
@@ -318,8 +312,6 @@ extension FeatureFlag: FeatureFlagDescribing {
              .supportsAlternateStripePaymentFlow,
              .personalInformationRemoval,
              .createFireproofFaviconUpdaterSecureVaultInBackground,
-             .scheduledSetDefaultBrowserPrompts,
-             .scheduledSetDefaultBrowserPromptsForInactiveUsers,
              .duckAISearchParameter,
              .inactivityNotification,
              .daxEasterEggLogos,
@@ -488,10 +480,6 @@ extension FeatureFlag: FeatureFlagDescribing {
             return .remoteReleasable(.subfeature(AIChatSubfeature.keepSession))
         case .showSettingsCompleteSetupSection:
             return .remoteReleasable(.subfeature(OnboardingSubfeature.showSettingsCompleteSetupSection))
-        case .scheduledSetDefaultBrowserPrompts:
-            return .remoteReleasable(.subfeature(SetAsDefaultAndAddToDockSubfeature.scheduledDefaultBrowserPrompts))
-        case .scheduledSetDefaultBrowserPromptsForInactiveUsers:
-            return .remoteReleasable(.subfeature(SetAsDefaultAndAddToDockSubfeature.scheduledDefaultBrowserPromptsInactiveUser))
         case .supportsAlternateStripePaymentFlow:
             return .remoteReleasable(.subfeature(PrivacyProSubfeature.supportsAlternateStripePaymentFlow))
         case .personalInformationRemoval:

iOS/DuckDuckGo/AppServices/DefaultBrowserPromptService.swift

@@ -57,7 +57,6 @@ final class DefaultBrowserPromptService {
         let promptActivityPixelHandler = DefaultBrowserPromptPixelHandler()
 
         presenter = DefaultBrowserPromptFactory.makeDefaultBrowserPromptPresenter(
-            featureFlagProvider: featureFlagAdapter,
             featureFlagSettingsProvider: featureFlagAdapter,
             promptActivityStore: promptTypeKeyValueFilesStore,
             userTypeProviding: userTypeManager,
@@ -74,15 +73,10 @@ final class DefaultBrowserPromptService {
 
     func resume() {
         // Application has been launched or brought to foreground.
-        guard shouldRecordActivity() else { return }
         Logger.defaultBrowserPrompt.debug("[Default Browser Prompt] - Record User Activity If Needed.")
         userActivityManager.recordActivity()
     }
 
-    private func shouldRecordActivity() -> Bool {
-        // True if either active/inactive prompt features is enabled
-        featureFlagAdapter.isDefaultBrowserPromptsForActiveUsersFeatureEnabled || featureFlagAdapter.isDefaultBrowserPromptsForInactiveUsersFeatureEnabled
-    }
 }
 
 // MARK: - Adapters

iOS/DuckDuckGo/DefaultBrowserPrompt/DefaultBrowserPromptFeatureFlagAdapter.swift

@@ -22,7 +22,7 @@ import Core
 import BrowserServicesKit
 import SetDefaultBrowserCore
 
-final class DefaultBrowserPromptFeatureFlagAdapter: DefaultBrowserPromptFeatureFlagProvider, DefaultBrowserPromptFeatureFlagSettingsProvider {
+final class DefaultBrowserPromptFeatureFlagAdapter: DefaultBrowserPromptFeatureFlagSettingsProvider {
 
     private let featureFlagger: FeatureFlagger
     private let privacyConfigurationManager: PrivacyConfigurationManaging
@@ -32,14 +32,6 @@ final class DefaultBrowserPromptFeatureFlagAdapter: DefaultBrowserPromptFeatureF
         self.privacyConfigurationManager = privacyConfigurationManager
     }
 
-    public var isDefaultBrowserPromptsForActiveUsersFeatureEnabled: Bool {
-        featureFlagger.isFeatureOn(FeatureFlag.scheduledSetDefaultBrowserPrompts)
-    }
-
-    public var isDefaultBrowserPromptsForInactiveUsersFeatureEnabled: Bool {
-        featureFlagger.isFeatureOn(FeatureFlag.scheduledSetDefaultBrowserPromptsForInactiveUsers)
-    }
-
     public var defaultBrowserPromptFeatureSettings: [String: Any] {
         privacyConfigurationManager.privacyConfig.settings(for: .setAsDefaultAndAddToDock)
     }

iOS/DuckDuckGo/DefaultBrowserPromptDebugView/DefaultBrowserPromptDebugView.swift

@@ -33,11 +33,7 @@ struct DefaultBrowserPromptDebugView: View {
     }
 
     var body: some View {
-        if model.isFeatureEnabled {
-            settingsView
-        } else {
-            Text(verbatim: "Feature Disabled. Ensure Internal user is On")
-        }
+        settingsView
     }
 
     @ViewBuilder
@@ -99,7 +95,6 @@ struct DefaultBrowserPromptDebugView: View {
                 }
             }
         }
-        .disabled(!model.isFeatureEnabled)
         .navigationTitle("Default Browser Prompt")
     }
 }
@@ -121,7 +116,6 @@ final class DefaultBrowserPromptDebugViewModel: ObservableObject {
         return formatter
     }()
 
-    @Published private(set) var isFeatureEnabled: Bool
     @Published private(set) var activeDaysCount: Int
     @Published private(set) var debugLog: DebugLog = .init()
     @Published var defaultBrowserPromptUserType: DefaultBrowserPromptUserType? {
@@ -155,7 +149,6 @@ final class DefaultBrowserPromptDebugViewModel: ObservableObject {
         currentDate = currentDateDebugStore.simulatedTodayDate
         formattedCurrentDate = Self.dateFormatter.string(from: currentDateDebugStore.simulatedTodayDate)
         activeDaysCount = userActivityStore.currentActivity().numberOfActiveDays
-        isFeatureEnabled = self.featureFlagger.isDefaultBrowserPromptsForActiveUsersFeatureEnabled
         makeDebugLog()
     }
 
@@ -180,7 +173,6 @@ final class DefaultBrowserPromptDebugViewModel: ObservableObject {
         defaultBrowserPromptUserType = userTypeDebugStore.userType()
         currentDate = currentDateDebugStore.simulatedTodayDate
         activeDaysCount = userActivityStore.currentActivity().numberOfActiveDays
-        isFeatureEnabled = self.featureFlagger.isDefaultBrowserPromptsForActiveUsersFeatureEnabled
         makeDebugLog()
     }
 

iOS/DuckDuckGoTests/DefaultBrowserPrompt/DefaultBrowserPromptFeatureFlagAdapterTests.swift

@@ -28,32 +28,6 @@ struct DefaultBrowserPromptFeatureFlagAdapterTests {
     private var featureFlaggerMock = MockFeatureFlagger(internalUserDecider: MockInternalUserDecider())
     private var privacyConfigurationManagerMock = MockPrivacyConfigurationManager()
 
-    @Test("Check Default Browser Prompts For Active Users Method Is Forwarded To Feature Flagger")
-    func checkIsActiveUsersFeatureOnIsForwardedToFeatureFlagger() {
-        // GIVEN
-        featureFlaggerMock.enabledFeatureFlags = [.scheduledSetDefaultBrowserPrompts]
-        let sut = DefaultBrowserPromptFeatureFlagAdapter(featureFlagger: featureFlaggerMock, privacyConfigurationManager: privacyConfigurationManagerMock)
-
-        // WHEN
-        let result = sut.isDefaultBrowserPromptsForActiveUsersFeatureEnabled
-
-        // THEN
-        #expect(result)
-    }
-
-    @Test("Check Default Browser Prompts For Inactive Users Method Is Forwarded To Feature Flagger")
-    func checkIsInactiveUsersFeatureOnIsForwardedToFeatureFlagger() {
-        // GIVEN
-        featureFlaggerMock.enabledFeatureFlags = [.scheduledSetDefaultBrowserPromptsForInactiveUsers]
-        let sut = DefaultBrowserPromptFeatureFlagAdapter(featureFlagger: featureFlaggerMock, privacyConfigurationManager: privacyConfigurationManagerMock)
-
-        // WHEN
-        let result = sut.isDefaultBrowserPromptsForInactiveUsersFeatureEnabled
-
-        // THEN
-        #expect(result)
-    }
-
     @Test("Check Method is Dispatched To Feature Flagger")
     func checkMethodIsDispatchedToPrivacyConfigurationManager() throws {
         // GIVEN

iOS/LocalPackages/SetDefaultBrowser/Sources/SetDefaultBrowserCore/FeatureFlagger/DefaultBrowserPromptFeatureFlagger.swift

@@ -19,20 +19,6 @@
 
 import Foundation
 
-public protocol DefaultBrowserPromptActiveUserFeatureFlagProvider {
-    /// A Boolean value indicating whether Set Default Browser Prompts are enabled for active users.
-    /// - Returns: `true` if the feature is enabled; otherwise, `false`.
-    var isDefaultBrowserPromptsForActiveUsersFeatureEnabled: Bool { get }
-}
-
-public protocol DefaultBrowserPromptInactiveUserFeatureFlagProvider {
-    /// A Boolean value indicating whether Set Default Browser Prompts are enabled for inactive users.
-    /// - Returns: `true` if the feature is enabled; otherwise, `false`.
-    var isDefaultBrowserPromptsForInactiveUsersFeatureEnabled: Bool { get }
-}
-
-public typealias DefaultBrowserPromptFeatureFlagProvider = DefaultBrowserPromptActiveUserFeatureFlagProvider & DefaultBrowserPromptInactiveUserFeatureFlagProvider
-
 public protocol DefaultBrowserPromptFeatureFlagSettingsProvider {
     // A dictionary representing the settings for the feature.
     var defaultBrowserPromptFeatureSettings: [String: Any] { get }
@@ -62,7 +48,7 @@ public enum DefaultBrowserPromptFeatureSettings: String {
     }
 }
 
-package protocol DefaultBrowserPromptActiveUserFeatureFlagger: DefaultBrowserPromptActiveUserFeatureFlagProvider {
+package protocol DefaultBrowserPromptActiveUserFeatureFlagger {
     /// The number of active days to wait after app installation before showing the first modal for active users. Default is 1.
     var firstActiveModalDelayDays: Int { get }
     /// The number of active days to wait after the first modal has been shown before displaying the second modal for active users. Default is 4.
@@ -71,7 +57,7 @@ package protocol DefaultBrowserPromptActiveUserFeatureFlagger: DefaultBrowserPro
     var subsequentActiveModalRepeatIntervalDays: Int { get }
 }
 
-package protocol DefaultBrowserPromptInactiveUserFeatureFlagger: DefaultBrowserPromptInactiveUserFeatureFlagProvider {
+package protocol DefaultBrowserPromptInactiveUserFeatureFlagger {
     /// The setting for the number of days to wait after app installation before showing the modal to inactive users. Default to 28.
     var inactiveModalNumberOfDaysSinceInstall: Int { get }
     /// The setting for the number of inactive days to wait before showing the modal to inactive users. Default to 7.
@@ -82,26 +68,16 @@ package typealias DefaultBrowserPromptFeatureFlagger = DefaultBrowserPromptActiv
 
 package final class DefaultBrowserPromptFeatureFlag {
     private let settingsProvider: DefaultBrowserPromptFeatureFlagSettingsProvider
-    private let featureFlagProvider: DefaultBrowserPromptFeatureFlagProvider
 
-    package init(settingsProvider: DefaultBrowserPromptFeatureFlagSettingsProvider, featureFlagProvider: DefaultBrowserPromptFeatureFlagProvider) {
+    package init(settingsProvider: DefaultBrowserPromptFeatureFlagSettingsProvider) {
         self.settingsProvider = settingsProvider
-        self.featureFlagProvider = featureFlagProvider
     }
 }
 
 // MARK: - DefaultBrowserPromptFeatureFlagger
 
 extension DefaultBrowserPromptFeatureFlag: DefaultBrowserPromptFeatureFlagger {
 
-    public var isDefaultBrowserPromptsForActiveUsersFeatureEnabled: Bool {
-        featureFlagProvider.isDefaultBrowserPromptsForActiveUsersFeatureEnabled
-    }
-
-    public var isDefaultBrowserPromptsForInactiveUsersFeatureEnabled: Bool {
-        featureFlagProvider.isDefaultBrowserPromptsForInactiveUsersFeatureEnabled
-    }
-
     package var firstActiveModalDelayDays: Int {
         getSettings(.firstActiveModalDelayDays)
     }

iOS/LocalPackages/SetDefaultBrowser/Sources/SetDefaultBrowserCore/PromptDecider/DefaultBrowserPromptTypeDecider+ActiveUser.swift

@@ -42,12 +42,6 @@ extension DefaultBrowserPromptTypeDecider {
 
 
         func promptType() -> DefaultBrowserPromptType? {
-            // If Feature is disabled return nil
-            guard featureFlagger.isDefaultBrowserPromptsForActiveUsersFeatureEnabled else {
-                Logger.defaultBrowserPrompt.debug("[Default Browser Prompt] - Feature disabled.")
-                return nil
-            }
-
             guard let userType = userTypeProvider.currentUserType() else {
                 Logger.defaultBrowserPrompt.debug("[Default Browser Prompt] - Failed to determine Active user type. Will not show prompt.")
                 return nil

iOS/LocalPackages/SetDefaultBrowser/Sources/SetDefaultBrowserCore/PromptDecider/DefaultBrowserPromptTypeDecider+InactiveUser.swift

@@ -38,8 +38,6 @@ extension DefaultBrowserPromptTypeDecider {
         }
 
         func promptType() -> DefaultBrowserPromptType? {
-            guard featureFlagger.isDefaultBrowserPromptsForInactiveUsersFeatureEnabled else { return nil }
-
             // Conditions to show prompt for inactive users:
             // 1. The user has not seen this modal ever.
             // 2. User has been inactive for at least seven days.

iOS/LocalPackages/SetDefaultBrowser/Sources/SetDefaultBrowserTestSupport/MockDefaultBrowserPromptFeatureFlag.swift

@@ -23,10 +23,6 @@ import SetDefaultBrowserCore
 public final class MockDefaultBrowserPromptFeatureFlag: DefaultBrowserPromptFeatureFlagger {
     public init() {}
 
-    public var isDefaultBrowserPromptsForActiveUsersFeatureEnabled: Bool = true
-
-    public var isDefaultBrowserPromptsForInactiveUsersFeatureEnabled: Bool = true
-
     public var firstActiveModalDelayDays: Int = 1
 
     public var secondActiveModalDelayDays: Int = 2
@@ -38,14 +34,6 @@ public final class MockDefaultBrowserPromptFeatureFlag: DefaultBrowserPromptFeat
     public var inactiveModalNumberOfInactiveDays: Int = 7
 }
 
-package final class MockDefaultBrowserPromptFeatureFlagProvider: DefaultBrowserPromptFeatureFlagProvider {
-    package var isDefaultBrowserPromptsForActiveUsersFeatureEnabled: Bool = true
-
-    package var isDefaultBrowserPromptsForInactiveUsersFeatureEnabled: Bool = true
-
-    package init() {}
-}
-
 package final class MockDefaultBrowserPromptFeatureFlagSettingsProvider: DefaultBrowserPromptFeatureFlagSettingsProvider {
     package var defaultBrowserPromptFeatureSettings: [String: Any] = [:]