chore: linting and formatting (triggered by new pre-commits).

Author: paultiq

_duckdb-stubs/_func.pyi

@@ -1,6 +1,14 @@
 import typing as pytyping
 
-__all__: list[str] = ["ARROW", "DEFAULT", "NATIVE", "SPECIAL", "FunctionNullHandling", "PythonUDFType"]
+__all__: list[str] = [
+    "ARROW",
+    "DEFAULT",
+    "NATIVE",
+    "SPECIAL",
+    "FunctionNullHandling",
+    "PythonTableUDFType",
+    "PythonUDFType",
+]
 
 class FunctionNullHandling:
     DEFAULT: pytyping.ClassVar[FunctionNullHandling]  # value = <FunctionNullHandling.DEFAULT: 0>
@@ -21,6 +29,25 @@ class FunctionNullHandling:
     @property
     def value(self) -> int: ...
 
+class PythonTableUDFType:
+    ARROW_TABLE: pytyping.ClassVar[PythonTableUDFType]  # value = <PythonTableUDFType.ARROW_TABLE: 1>
+    TUPLES: pytyping.ClassVar[PythonTableUDFType]  # value = <PythonTableUDFType.TUPLES: 0>
+    __members__: pytyping.ClassVar[
+        dict[str, PythonTableUDFType]
+    ]  # value = {'TUPLES': <PythonTableUDFType.TUPLES: 0>, 'ARROW_TABLE': <PythonTableUDFType.ARROW_TABLE: 1>}
+    def __eq__(self, other: object) -> bool: ...
+    def __getstate__(self) -> int: ...
+    def __hash__(self) -> int: ...
+    def __index__(self) -> int: ...
+    def __init__(self, value: pytyping.SupportsInt) -> None: ...
+    def __int__(self) -> int: ...
+    def __ne__(self, other: object) -> bool: ...
+    def __setstate__(self, state: pytyping.SupportsInt) -> None: ...
+    @property
+    def name(self) -> str: ...
+    @property
+    def value(self) -> int: ...
+
 class PythonUDFType:
     ARROW: pytyping.ClassVar[PythonUDFType]  # value = <PythonUDFType.ARROW: 1>
     NATIVE: pytyping.ClassVar[PythonUDFType]  # value = <PythonUDFType.NATIVE: 0>

duckdb/func/__init__.py

@@ -1,3 +1,11 @@
-from _duckdb._func import ARROW, DEFAULT, NATIVE, SPECIAL, FunctionNullHandling, PythonTableUDFType, PythonUDFType  # noqa: D104
+from _duckdb._func import (  # noqa: D104
+    ARROW,
+    DEFAULT,
+    NATIVE,
+    SPECIAL,
+    FunctionNullHandling,
+    PythonTableUDFType,
+    PythonUDFType,
+)
 
 __all__ = ["ARROW", "DEFAULT", "NATIVE", "SPECIAL", "FunctionNullHandling", "PythonTableUDFType", "PythonUDFType"]

tests/fast/table_udf/test_arrow.py

@@ -1,4 +1,4 @@
-from typing import Iterator
+from collections.abc import Iterator
 
 import pytest
 
@@ -25,8 +25,8 @@ def simple_arrow_table(count: int):
 
 def arrow_all_types(count: int):
     pa = pytest.importorskip("pyarrow")
-    from decimal import Decimal
     from datetime import datetime, timedelta, timezone
+    from decimal import Decimal
 
     now = datetime.now(timezone.utc)
     data = {
@@ -81,10 +81,7 @@ def arrow_all_types(count: int):
 
 
 def test_arrow_small(tmp_path):
-    """Defines and creates a Table UDF with only positional parameters, verifies that it works
-    and verifies it fails from another connection scope.
-    """
-    pa = pytest.importorskip("pyarrow")
+    pytest.importorskip("pyarrow")
 
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         conn.create_table_function(
@@ -117,7 +114,7 @@ def test_arrow_small(tmp_path):
 
 def test_arrow_large_1(tmp_path):
     """tests: more rows, aggregation, limits, named parameters, parameters."""
-    pa = pytest.importorskip("pyarrow")
+    pytest.importorskip("pyarrow")
 
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         n = 2048 * 1000
@@ -201,8 +198,8 @@ def test_arrowbatched_sql_relation(tmp_path):
 
 
 def test_arrow_types(tmp_path):
-    """Return many types from an arrow table UDF, and verify the results are correct"""
-    pa = pytest.importorskip("pyarrow")
+    """Return many types from an arrow table UDF, and verify the results are correct."""
+    pytest.importorskip("pyarrow")
 
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         conn.create_table_function(

tests/fast/table_udf/test_arrow_schema.py

@@ -1,5 +1,3 @@
-"""Test Arrow Table UDF schema validation"""
-
 import pytest
 
 import duckdb
@@ -19,7 +17,7 @@ def simple_arrow_table(count: int = 10):
 
 
 def test_arrow_correct_schema(tmp_path):
-    pa = pytest.importorskip("pyarrow")
+    pytest.importorskip("pyarrow")
 
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         conn.create_table_function(
@@ -35,7 +33,7 @@ def test_arrow_correct_schema(tmp_path):
 
 
 def test_arrow_more_columns(tmp_path):
-    pa = pytest.importorskip("pyarrow")
+    pytest.importorskip("pyarrow")
 
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         # table has 3 cols, but declare only 2
@@ -54,7 +52,7 @@ def test_arrow_more_columns(tmp_path):
 
 
 def test_arrow_fewer_columns(tmp_path):
-    pa = pytest.importorskip("pyarrow")
+    pytest.importorskip("pyarrow")
 
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         # table has 3 columns, but declare 4
@@ -78,7 +76,7 @@ def test_arrow_fewer_columns(tmp_path):
 
 
 def test_arrow_type_mismatch(tmp_path):
-    pa = pytest.importorskip("pyarrow")
+    pytest.importorskip("pyarrow")
 
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         conn.create_table_function(
@@ -100,7 +98,7 @@ def test_arrow_type_mismatch(tmp_path):
 
 
 def test_arrow_name_mismatch_allowed(tmp_path):
-    pa = pytest.importorskip("pyarrow")
+    pytest.importorskip("pyarrow")
 
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         conn.create_table_function(

tests/fast/table_udf/test_register.py

@@ -109,7 +109,7 @@ def func_v3():
 
 
 def test_multiple_replacements(tmp_path):
-    """Replacing Table UDFs multiple times"""
+    """Replacing Table UDFs multiple times."""
     with duckdb.connect(tmp_path / "test.db") as conn:
         schema = {"value": sqltypes.INTEGER}
 
@@ -131,7 +131,7 @@ def func():
 
 
 def test_replacement_with_different_schemas(tmp_path):
-    """Changing schema with replacements"""
+    """Changing schema with replacements."""
     with duckdb.connect(tmp_path / "test.db") as conn:
 
         def func_v1():
@@ -184,7 +184,7 @@ def func_v2():
 
 
 def test_sql_drop_table_function(tmp_path):
-    """Documents current behavior - that dropping functions has no effect on Table UDFs"""
+    """Documents current behavior - that dropping functions has no effect on Table UDFs."""
     with duckdb.connect(tmp_path / "test.db") as conn:
 
         def test_func():
@@ -197,7 +197,7 @@ def test_func():
         assert result[0][0] == "test_value"
         assert result[0][1] == 1
 
-        with pytest.raises(Exception):
+        with pytest.raises(duckdb.CatalogException):
             conn.execute("DROP FUNCTION test_func")
 
         result = conn.execute("SELECT * FROM test_func()").fetchall()
@@ -306,7 +306,6 @@ def test_func():
 
         cursor1.unregister_table_function("shared_func")
 
-        # TODO: Decide whether to keep this unregister behavior
         result1 = cursor1.execute("SELECT * FROM shared_func()").fetchall()
         assert result1[0][0] == "test_data"
 

tests/fast/table_udf/test_schema.py

@@ -1,6 +1,6 @@
 """Test schema validation for table-valued functions."""
 
-from typing import Iterator
+from collections.abc import Iterator
 
 import pytest
 
@@ -141,28 +141,32 @@ def test_invalid_schema_none(tmp_path):
     def gen_function():
         return [("test", 1)]
 
-    with duckdb.connect(tmp_path / "test.duckdb") as conn:
-        with pytest.raises(duckdb.InvalidInputException, match="Table functions require a schema"):
-            conn.create_table_function(
-                name="gen_function",
-                callable=gen_function,
-                schema=None,
-                type="tuples",
-            )
+    with (
+        duckdb.connect(tmp_path / "test.duckdb") as conn,
+        pytest.raises(duckdb.InvalidInputException, match="Table functions require a schema"),
+    ):
+        conn.create_table_function(
+            name="gen_function",
+            callable=gen_function,
+            schema=None,
+            type="tuples",
+        )
 
 
 def test_invalid_schema_empty_dict(tmp_path):
     def gen_function():
         return [("test", 1)]
 
-    with duckdb.connect(tmp_path / "test.duckdb") as conn:
-        with pytest.raises(duckdb.InvalidInputException, match="schema cannot be empty"):
-            conn.create_table_function(
-                name="gen_function",
-                callable=gen_function,
-                schema={},
-                type="tuples",
-            )
+    with (
+        duckdb.connect(tmp_path / "test.duckdb") as conn,
+        pytest.raises(duckdb.InvalidInputException, match="schema cannot be empty"),
+    ):
+        conn.create_table_function(
+            name="gen_function",
+            callable=gen_function,
+            schema={},
+            type="tuples",
+        )
 
 
 def test_invalid_schema_list_format(tmp_path):
@@ -207,7 +211,7 @@ def gen_function():
         # String types should be rejected
         schema = {"name": "VARCHAR", "id": "INT"}
 
-        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb.sqltype"):
+        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb\\.sqltype"):
             conn.create_table_function(
                 name="gen_function",
                 callable=gen_function,
@@ -223,7 +227,7 @@ def gen_function():
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         schema = {"name": sqltypes.VARCHAR, "id": 123}
 
-        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb.sqltype"):
+        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb\\.sqltype"):
             conn.create_table_function(
                 name="gen_function",
                 callable=gen_function,
@@ -239,7 +243,7 @@ def gen_function():
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         schema = {"name": sqltypes.VARCHAR, "id": None}
 
-        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb.sqltype"):
+        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb\\.sqltype"):
             conn.create_table_function(
                 name="gen_function",
                 callable=gen_function,
@@ -258,7 +262,7 @@ def gen_function():
         # Mix of DuckDBPyType and string - should reject strings
         schema = {"name": sqltypes.VARCHAR, "id": "INT", "value": sqltypes.DOUBLE}
 
-        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb.sqltype"):
+        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb\\.sqltype"):
             conn.create_table_function(
                 name="gen_function",
                 callable=gen_function,
@@ -274,7 +278,7 @@ def gen_function():
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         schema = {"name": str, "id": int}
 
-        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb.sqltype"):
+        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb\\.sqltype"):
             conn.create_table_function(
                 name="gen_function",
                 callable=gen_function,
@@ -399,7 +403,7 @@ def gen_function():
     with duckdb.connect(tmp_path / "test.duckdb") as conn:
         schema = {"name": sqltypes.VARCHAR, "id": 123}  # int is not valid
 
-        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb.sqltype"):
+        with pytest.raises(duckdb.InvalidInputException, match="must be a duckdb\\.sqltype"):
             conn.create_table_function(
                 name="gen_function",
                 callable=gen_function,

tests/fast/table_udf/test_tuples.py

@@ -177,7 +177,7 @@ def simple_pylist(count, foo=10):
 
 
 def test_large_2(tmp_path):
-    """Aggregation and filtering"""
+    """Aggregation and filtering."""
     with duckdb.connect(tmp_path / "test.db") as conn:
         count = 500000
 
@@ -235,7 +235,8 @@ def test_error(tmp_path):
     with duckdb.connect(tmp_path / "test.db") as conn:
 
         def error_function():
-            raise ValueError("Intentional")
+            error_message = "Intentional Error"
+            raise ValueError(error_message)
 
         schema = {"name": sqltypes.VARCHAR, "id": sqltypes.INTEGER}
 

tests/fast/table_udf/test_tuples_datatypes.py

@@ -1,5 +1,3 @@
-import pytest
-
 import duckdb
 import duckdb.sqltypes as sqltypes
 
@@ -36,7 +34,7 @@ def hugeint_func(huge_value):
         )
 
         huge_val = 9223372036854775808
-        result = conn.sql(f"SELECT * FROM hugeint_func(?)", params=(huge_val,)).fetchall()
+        result = conn.sql("SELECT * FROM hugeint_func(?)", params=(huge_val,)).fetchall()
         assert result[0][0] == huge_val
         assert result[0][1] == huge_val + 1
 
@@ -74,5 +72,5 @@ def uuid_func(uuid_value):
         )
 
         test_uuid = "550e8400-e29b-41d4-a716-446655440000"
-        result = conn.sql(f"SELECT * FROM uuid_func(?::uuid)", params=(test_uuid,)).fetchall()
+        result = conn.sql("SELECT * FROM uuid_func(?::uuid)", params=(test_uuid,)).fetchall()
         assert str(result[0][0]) == test_uuid