Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pandas DataFrame Reader Example To Use Built-In Reader #1146

Open
mkierzenka opened this issue Mar 21, 2025 · 1 comment
Open

Update Pandas DataFrame Reader Example To Use Built-In Reader #1146

mkierzenka opened this issue Mar 21, 2025 · 1 comment

Comments

@mkierzenka
Copy link

The Use of Custom Readers that support Pandas DataFrames example is helpful to learn about how to implement a custom data reader in Stone Soup, but I think it may be confusing to new users. When I first read it, I thought it implied that in order to add support for reading truth/measurement data from DataFrames I needed to write my own _DataFrameReader, DataFrameGroundTruthReader, and DataFrameDetectionReader classes as shown in the first section of that example. However, these classes are now natively included in Stone Soup: stonesoup/reader/pandas_reader.py.

Perhaps this example should be updated to remove those sections showing reimplemented code and instead utilize the built-in classes? What do you think?

@apiszcz
Copy link

apiszcz commented Mar 22, 2025

FYSA: #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants