-
Notifications
You must be signed in to change notification settings - Fork 202
Open
Labels
Description
I think we can remove the explicit adding of the value to our cacheability information in
graphql/src/GraphQL/Resolver/ParentValue.php
Lines 19 to 21 in fa9764f
| if ($value instanceof CacheableDependencyInterface) { | |
| $context->addCacheableDependency($value); | |
| } |
Since we already do so for all the results in our field resolver
Lines 354 to 358 in fa9764f
| if ($result instanceof CacheableDependencyInterface) { | |
| $field->addCacheableDependency($result); | |
| } | |
| $context->addCacheableDependency($field); |
This may seem like a small optimisation, but when looking at a relatively complex query addCacheableDependency was actually a place where the most time was spent and I theFromParent producer is actually on a hot path because a lot of fields use the parent's value to refine it further, so removing this unneeded function call may make a difference.