You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
App.js is currently mostly concerned with loading a file from LORIS. MincLoader.js is mostly concerned with parsing it, while Viewer.js is mostly concerned with displaying it.
The loading part is incidental and not the core of this project, it should probably be moved to a different repo (or at least clearly distinguished in this one) which can morph into a fully featured "LORIS Imaging" app that incorporates different functionality from the LORIS API distinct from viewing the file (like the LORIS Imaging Browser on the web: QC, browsing and selecting a file, etc) and use this as a library (similarly to how LORIS uses BrainBrowser on the web side). The file loading parts would also ideally be separated into a different package that could be used more generically (ie. shared between BrainBrowser for the web and this for mobile since they're both written in javascript, but also used by anyone who wants to parse data into raw coordinates in javascript for processing.)
(I'm not sure what's to discuss here, this started as an issue and then I realized there's not much that's actionable on it at the moment so I created a discussion for it as a place to write down my thoughts.. at the moment the 3 roles are pretty clearly distinguished in different files, but that's more incidental than by design. If anyone has any thoughts on how to structure this I'd be interested in hearing them.)
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
App.js
is currently mostly concerned with loading a file from LORIS.MincLoader.js
is mostly concerned with parsing it, whileViewer.js
is mostly concerned with displaying it.The loading part is incidental and not the core of this project, it should probably be moved to a different repo (or at least clearly distinguished in this one) which can morph into a fully featured "LORIS Imaging" app that incorporates different functionality from the LORIS API distinct from viewing the file (like the LORIS Imaging Browser on the web: QC, browsing and selecting a file, etc) and use this as a library (similarly to how LORIS uses BrainBrowser on the web side). The file loading parts would also ideally be separated into a different package that could be used more generically (ie. shared between BrainBrowser for the web and this for mobile since they're both written in javascript, but also used by anyone who wants to parse data into raw coordinates in javascript for processing.)
(I'm not sure what's to discuss here, this started as an issue and then I realized there's not much that's actionable on it at the moment so I created a discussion for it as a place to write down my thoughts.. at the moment the 3 roles are pretty clearly distinguished in different files, but that's more incidental than by design. If anyone has any thoughts on how to structure this I'd be interested in hearing them.)
Beta Was this translation helpful? Give feedback.
All reactions