Skip to content

Commit 08ff638

Browse files
committed
refactor(test): remove default node version
1 parent a54fbbe commit 08ff638

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ on:
44
workflow_call:
55
inputs:
66
node-version:
7+
required: false
78
description: "Node version on which to run the tests"
8-
type: number
9-
default: 20
9+
type: string
1010

1111
secrets:
1212
turbo_token:
@@ -29,10 +29,10 @@ jobs:
2929
- name: Install pnpm
3030
uses: pnpm/action-setup@v3
3131

32-
# TODO: partition cache based on inputs (os)
3332
- name: Setup Node
3433
uses: actions/setup-node@v4
3534
with:
35+
node-version-file: .node-version
3636
node-version: ${{ env.NODE_VERSION }}
3737
cache: "pnpm"
3838

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
test:
3737
uses: driimus/shared-workflows/.github/workflows/test.yml@main
3838
with:
39-
node-version: 20
39+
node-version: 22
4040
# Optional Turborepo credentials to use for Remote Caching
4141
secrets:
4242
turbo_token: ${{ secrets.TURBO_TOKEN }}

0 commit comments

Comments
 (0)