Import Failures

[dcompiled]

The code in strategies/python.py masks errors that occur during the import process. I spent several hours looking into why imports were not working on a remotely managed box and it boiled down to problems with a settings file failing to import.

    @staticmethod
    def is_valid_file(file_name):
        try:
            importlib.import_module(file_name)
            return True
        except (ImportError, TypeError):
            return False

Add some logging with the exception to help pinpoint issues.

[igolkotek]

Agree,
Had the same situation.

Even this change could help.

    @staticmethod
    def is_valid_file(file_name):
        try:
            importlib.import_module(file_name)
            return True
        except (ImportError, TypeError) as e:
            logger.error(e)
            logger.info("Cannot load {} as python settings file".format(file_name))
            return False

[gandhis1]

Exactly - it ends up hiding import error information.