Updated feedback.

Author: AlexSkrypnyk

.vortex/installer/src/Command/InstallCommand.php

@@ -11,6 +11,7 @@
 use DrevOps\VortexInstaller\Runner\CommandRunnerAwareTrait;
 use DrevOps\VortexInstaller\Runner\ExecutableFinderAwareInterface;
 use DrevOps\VortexInstaller\Runner\ExecutableFinderAwareTrait;
+use DrevOps\VortexInstaller\Runner\RunnerInterface;
 use DrevOps\VortexInstaller\Task\Task;
 use DrevOps\VortexInstaller\Utils\Config;
 use DrevOps\VortexInstaller\Utils\Env;
@@ -452,7 +453,7 @@ protected function runBuildCommand(OutputInterface $output): bool {
     $runner = $this->getCommandRunner();
     $runner->run('build', args: $is_profile ? ['--profile' => '1'] : [], output: $output);
 
-    return $runner->getExitCode() === Command::SUCCESS;
+    return $runner->getExitCode() === RunnerInterface::EXIT_SUCCESS;
   }
 
   protected function header(): void {
@@ -721,7 +722,7 @@ public function cleanup(): void {
    *   The downloader.
    */
   protected function getDownloader(): Downloader {
-    return $this->downloader ?? new Downloader();
+    return $this->downloader ??= new Downloader();
   }
 
   /**

.vortex/installer/src/Runner/AbstractRunner.php

@@ -205,7 +205,7 @@ public function getOutput(bool $as_array = FALSE, ?int $lines = NULL): string |
   protected function reset(): void {
     $this->command = NULL;
     $this->output = '';
-    $this->exitCode = self::EXIT_SUCCESS;
+    $this->exitCode = RunnerInterface::EXIT_SUCCESS;
   }
 
   /**

.vortex/installer/src/Runner/CommandRunnerAwareTrait.php

@@ -25,7 +25,7 @@ trait CommandRunnerAwareTrait {
    */
   public function getCommandRunner(): CommandRunner {
     // @phpstan-ignore-next-line
-    return $this->commandRunner ?? new CommandRunner($this->getApplication());
+    return $this->commandRunner ??= new CommandRunner($this->getApplication());
   }
 
   /**

.vortex/installer/src/Runner/ProcessRunner.php

@@ -141,7 +141,11 @@ protected function resolveCommand(string $command): array {
   protected function prepareArguments(array $parsed_args, array $additional_args): array {
     $all_args = array_merge($parsed_args, $this->formatArgs($additional_args));
 
-    foreach ($all_args as &$arg) {
+    foreach ($all_args as $key => &$arg) {
+      if (!is_scalar($arg)) {
+        $value_repr = get_debug_type($arg);
+        throw new \InvalidArgumentException(sprintf('Argument at index "%s" must be a scalar value, %s given.', $key, $value_repr));
+      }
       $arg = (string) $arg;
     }
     unset($arg);
@@ -159,9 +163,10 @@ protected function prepareArguments(array $parsed_args, array $additional_args):
    *   When an environment variable is not a scalar value.
    */
   protected function validateEnvironmentVars(array $env): void {
-    foreach ($env as $env_value) {
+    foreach ($env as $key => $env_value) {
       if (!is_scalar($env_value)) {
-        throw new \InvalidArgumentException('All environment variables must be scalar values.');
+        $value_repr = get_debug_type($env_value);
+        throw new \InvalidArgumentException(sprintf('Environment variable "%s" must be a scalar value, %s given.', $key, $value_repr));
       }
     }
   }

.vortex/installer/src/Runner/ProcessRunnerAwareTrait.php

@@ -23,7 +23,7 @@ trait ProcessRunnerAwareTrait {
    *   The process runner instance.
    */
   public function getProcessRunner(): ProcessRunner {
-    return $this->processRunner ?? new ProcessRunner();
+    return $this->processRunner ??= new ProcessRunner();
   }
 
   /**

.vortex/installer/tests/Functional/Command/CheckRequirementsCommandTest.php

@@ -72,7 +72,7 @@ public function testCheckRequirementsCommand(
   }
 
   /**
-   * Data provider for testCheckWithMockedRunner.
+   * Data provider for testCheckRequirementsCommand.
    *
    * @return array<string, array{
    *   executable_finder_callback: \Closure,

.vortex/installer/tests/Unit/Runner/ProcessRunnerTest.php

@@ -136,8 +136,7 @@ public function testValidateEnvironmentVars(array $env, ?string $expected_except
     $runner->validateEnvironmentVarsPublic($env);
 
     if ($expected_exception === NULL) {
-      // @phpstan-ignore-next-line
-      $this->assertTrue(TRUE, 'Validation passed');
+      $this->addToAssertionCount(1);
     }
   }
 

.vortex/tests/phpunit/Traits/SutTrait.php

@@ -74,12 +74,12 @@ protected function runInstaller(array $arguments = []): void {
 
     if (!is_dir(static::$root . '/.vortex/installer/vendor')) {
       $this->logNote('Installing dependencies of the Vortex installer');
-      $this->cmd('composer --working-dir=' . static::$root . '/.vortex/installer install --no-interaction --no-progress');
+      $this->cmd('composer --working-dir=' . escapeshellarg(static::$root . '/.vortex/installer') . ' install --no-interaction --no-progress');
     }
 
     // @todo Convert options to $arguments once
     // ProcessTrait::processParseCommand() is fixed.
-    $cmd = sprintf('php .vortex/installer/installer.php --no-interaction --destination=%s', static::locationsSut());
+    $cmd = sprintf('php .vortex/installer/installer.php --no-interaction --destination=%s', escapeshellarg(static::locationsSut()));
 
     $this->logNote('Run the installer script');
     $this->cmd(
@@ -134,14 +134,14 @@ protected function buildInstaller(): string {
 
     if (!is_dir($installer_dir)) {
       $this->logNote('Installing dependencies of the Vortex installer');
-      $this->cmd('composer --working-dir=' . $installer_dir . ' install --no-interaction --no-progress');
+      $this->cmd('composer --working-dir=' . escapeshellarg($installer_dir) . ' install --no-interaction --no-progress');
       $this->assertDirectoryExists($installer_dir . '/vendor', 'Vortex installer vendor directory should exist after installing dependencies');
     }
 
-    $this->cmd('composer --working-dir=' . $installer_dir . ' build', env: ['SHELL_VERBOSITY' => -1], txt: 'Build the Vortex installer PHAR');
+    $this->cmd('composer --working-dir=' . escapeshellarg($installer_dir) . ' build', env: ['SHELL_VERBOSITY' => -1], txt: 'Build the Vortex installer PHAR');
     $this->assertFileExists($installer_phar, 'Installer PHAR should be built');
 
-    $this->cmd('php ' . $installer_phar . ' --version');
+    $this->cmd('php ' . escapeshellarg($installer_phar) . ' --version');
     $this->logNote('Built Vortex installer: ' . trim($this->processGet()->getOutput()));
 
     return $installer_phar;