Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server hint empty sent #30

Open
rpablos opened this issue Jan 18, 2024 · 0 comments
Open

server hint empty sent #30

rpablos opened this issue Jan 18, 2024 · 0 comments

Comments

@rpablos
Copy link

rpablos commented Jan 18, 2024

There is an issue with server hint and some clients will not work properly.
If you don't specify a server hint, the server hint should not be sent. But in the code what you specify finally is a zero-length bytes object, so you get the hint sent with length equals to zero.

What I did for not changing the c source is:

-In sslpsk.py, in function _ssl_set_psk_server_callback, change
_ = _sslpsk.sslpsk_use_psk_identity_hint(_sslobj(sock), hint if hint else b"")
for

 if hint:
        _      = _sslpsk.sslpsk_use_psk_identity_hint(_sslobj(sock), hint)

regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant