You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you so much for providing this useful library!
I ran into an issue where I couldn't see the value on mouseover if my diex and diey values in xyd were floats (1.0 instead of 1). I could fix this by setting them to integers in my data tuples, but it also worked to change xyd_to_dict() to cast the x and y values as integers:
def xyd_to_dict(xyd_list):
"""Convert the xyd list to a dict of xNNyNN key-value pairs."""
return {"x{}y{}".format(int(_x), int(_y)): _d for _x, _y, _d in xyd_list}
I wonder if this should be implemented, or if there is a downside that I don't see.
The text was updated successfully, but these errors were encountered:
To be honest it's been a looong time since I've looked at this code, so I'm 100% sure that implementing the change will have 0 side effects, but it sure does look like it'll be benign. I'm also seeing that my past self made some pretty terrible design choices when making this project, haha.
If you want to submit a PR for the change I'll gladly review it and merge it.
Thank you so much for providing this useful library!
I ran into an issue where I couldn't see the value on mouseover if my diex and diey values in xyd were floats (1.0 instead of 1). I could fix this by setting them to integers in my data tuples, but it also worked to change xyd_to_dict() to cast the x and y values as integers:
I wonder if this should be implemented, or if there is a downside that I don't see.
The text was updated successfully, but these errors were encountered: