Make replication flush interval configurable in mysql source #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhojha
force-pushed
the
saurabh/transfer/configure-flush-intervals
branch
from
8b64ab2 to
c9109c2
Compare
saurabhojha
force-pushed
the
saurabh/transfer/configure-flush-intervals
branch
from
c9109c2 to
178fab7
Compare
laskoviymishka
approved these changes
Feb 6, 2025
|
@laskoviymishka has imported your pull request. If you are a member of Transfer team, you can view this diff. |
boooec
suggested changes
Feb 12, 2025
Comment on lines
+174
to
+175
| - **ReplicationFlushInterval** (`time.Duration`): Specifies the replication flush interval. Defined in nanoseconds. | ||
| - Example: `5000000000` (5 seconds) |
There was a problem hiding this comment.
Let's change it to milliseconds (1/1000 of second). I don't see a case when user will need to specify interval with such accuracy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a replication flush interval in mysql source config.
This pr closes : #59