[BUG] dify: dify-plugin-daemon env DB_DATABASE duplicate

[omegazeng]

Describe the bug

The Deployment dify-plugin-daemon env has a duplicate item DB_DATABASE

To Reproduce

helm install test douban/dify -n dify --version 0.6.2 --debug --dry-run

Expected behavior
only 1 env DB_DATABASE

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

# Source: dify/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: test-dify-plugin-daemon
  labels:
    helm.sh/chart: dify-0.6.2
    app.kubernetes.io/name: dify
    app.kubernetes.io/instance: test
    app.kubernetes.io/version: "1.1.0"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/component: plugin-daemon
    
spec:
  replicas: 1
  strategy:
    type: Recreate
  selector:
    matchLabels:
      app.kubernetes.io/name: dify
      app.kubernetes.io/instance: test
      app.kubernetes.io/component: plugin-daemon
  template:
    metadata:
      labels:
        app.kubernetes.io/name: dify
        app.kubernetes.io/instance: test
        app.kubernetes.io/component: plugin-daemon
        
    spec:
      serviceAccountName: test-dify
      securityContext:
        null
      containers:
        - name: dify-plugin-daemon
          securityContext:
            null
          image: "langgenius/dify-plugin-daemon:0.0.5-local"
          imagePullPolicy: IfNotPresent
          env:
            - name: DIFY_INNER_API_URL
              value: "http://test-dify-api-svc:80"
            - name: PLUGIN_WORKING_PATH
              value: "/app/storage/cwd"
            - name: SERVER_KEY
              value: "lYkiYYT6owG+71oLerGzA7GXCgOT++6ovaezWAjpCjf+Sjc3ZtU+qUEi"
            - name: DIFY_INNER_API_KEY
              value: "QaHbTe77CtuXmsfyhR7+vRjI/+XbV1AaFy691iy+kGDv2Jvy0/eAh8Y1"
            - name: EDITION
              value: SELF_HOSTED
            - name: CONSOLE_API_URL
              value: http://chart-example.local
            - name: CONSOLE_WEB_URL
              value: http://chart-example.local
            - name: SERVICE_API_URL
              value: http://chart-example.local
            - name: APP_API_URL
              value: http://chart-example.local
            - name: APP_WEB_URL
              value: http://chart-example.local
            - name: STORAGE_TYPE
              value: s3
            - name: CELERY_BROKER_URL
              value: redis://:REDIS_PASSWORD@test-dify-redis-master:6379/1
            - name: REDIS_PORT
              value: "6379"
            - name: REDIS_HOST
              value: test-dify-redis-master
            - name: REDIS_DB
              value: "1"
            - name: REDIS_PASSWORD
              value: REDIS_PASSWORD
            - name: DB_USERNAME
              value: postgres
            - name: DB_PASSWORD
              value: "testpassword"
            - name: DB_HOST
              value: test-dify-postgresql
            - name: DB_PORT
              value: "5432"
            - name: DB_DATABASE
              value: dify
            - name: PLUGIN_DAEMON_URL
              value: "http://test-dify-plugin-daemon:5002"
            - name: MARKETPLACE_API_URL
              value: 'https://marketplace.dify.ai'
            - name: PLUGIN_DAEMON_KEY
              value: "lYkiYYT6owG+71oLerGzA7GXCgOT++6ovaezWAjpCjf+Sjc3ZtU+qUEi"
            - name: PLUGIN_DIFY_INNER_API_KEY
              value: "QaHbTe77CtuXmsfyhR7+vRjI/+XbV1AaFy691iy+kGDv2Jvy0/eAh8Y1"
            - name: SECRET_KEY
              value: PleaseReplaceThisToYourSecretOrUse
            - name: SERVER_PORT
              value: "5002"
            - name: MAX_PLUGIN_PACKAGE_SIZE
              value: "52428800"
            - name: PPROF_ENABLED
              value: "false"
            - name: FORCE_VERIFYING_SIGNATURE
              value: "true"
            - name: DB_DATABASE
              value: dify_plugin
            - name: PLUGIN_REMOTE_INSTALLING_HOST
              value: 0.0.0.0
            - name: PLUGIN_REMOTE_INSTALLING_PORT
              value: "5003"
          volumeMounts:
            - name: plugin-daemon-storage
              mountPath: /app/storage
          ports:
            - name: http
              containerPort: 5002
              protocol: TCP
          resources:
            {}
      volumes:
        - name: plugin-daemon-storage
          persistentVolumeClaim:
            claimName: test-dify-plugin-daemon-pvc

[LeoQuote]

Thank you for reporting this issue and providing detailed steps to reproduce it.

You're absolutely correct about the duplicate DB_DATABASE environment variable in the plugin-daemon deployment. The current Helm chart design shares many environment variables across backend components (api/worker/plugin-daemon), but some edge cases like this require component-specific configurations.

While the ultimate fix would involve refactoring environment variable rendering to decouple these components, this is unfortunately a non-trivial effort that I can't prioritize immediately due to time constraints. Contributions via PR are highly welcome if you'd like to propose a solution!

For context, the duplicate definition is functionally harmless in Kubernetes - the latter value takes precedence, and the application will work as expected. This only produces a warning during helm install/upgrade, not an error.

Appreciate your attention to detail in catching this, and please don't hesitate to follow up if you have other questions or suggestions.

[omegazeng]

helm upgrade

warnings.go:70] spec.template.spec.containers[0].env[37]: hides previous definition of "DB_DATABASE", which may be dropped when using apply

[bulolo]

W0522 10:51:38.920034 4637 warnings.go:70] spec.template.spec.containers[0].env[37].name: duplicate name "DB_DATABASE"

[bulolo]

#123