-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building the host-targeting components and packing ILC #111552
Conversation
…the SDK (it's not set before Subsets.props)
…do with crossgen2.
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Yeah I've checked all of the binlogs and they're doing the right thing (no sfx in the tools dir). I'm going to merge this in. |
I was building it in GHA but it was using main branch https://github.com/am11/CrossRepoCITesting/releases/tag/linux_x64_12836857446. The PR branch did removed the extra files https://github.com/am11/CrossRepoCITesting/releases/tag/linux_x64_12837954845. Sorry for the confusion. Good fix! 👍 |
NETCoreSdkRuntimeIdentifier
isn't set until after the Microsoft.NET.Sdk'sSdk.props
file has been imported fully. Use the "after Sdk props" hook to set the "should build host tools" property so project files and item groups in Subsets.props can see the correct property value.Also change how we publish ILCompiler to better follow the model of crossgen2. This restores the expected behavior of publishing an AOT or single-file ilc.
Fixes failures in dotnet/sdk#45990