Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround error G6E97C40B #111459

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Workaround error G6E97C40B #111459

merged 2 commits into from
Jan 15, 2025

Conversation

dkurt
Copy link
Contributor

@dkurt dkurt commented Jan 15, 2025

/home/runner/work/dotnet_riscv/dotnet_riscv/runtime/src/native/external/zlib-ng/arch/riscv/riscv_features.c(25,33): error G6E97C40B: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] [/home/runner/work/dotnet_riscv/dotnet_riscv/runtime/src/native/libs/build-native.proj]

when compile using GCC with RVV enabled

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 15, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 15, 2025
@jkotas
Copy link
Member

jkotas commented Jan 15, 2025

Could you please submit the same change to the upstream zlib-ng project and mention the upstream pull request in https://github.com/dotnet/runtime/blob/main/src/native/external/zlib-ng-version.txt#L14

@jkotas jkotas added arch-riscv Related to the RISC-V architecture area-System.IO.Compression and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 15, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jan 15, 2025

/ba-g infrastructure timeout

@jkotas jkotas merged commit 4c7991c into dotnet:main Jan 15, 2025
143 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-riscv Related to the RISC-V architecture area-System.IO.Compression community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants