Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging internal commits for release/8.0 #111430

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Merging internal commits for release/8.0 #111430

merged 6 commits into from
Jan 15, 2025

Conversation

vseanreesermsft
Copy link

No description provided.

Mirroring and others added 6 commits November 5, 2024 21:26
Merge commit 'c1ae962610643a3c17bcf9621017ac42ff7703f7'
6384931
Merge commit '18be5f154b6f49849978a6136c5595bbfbef588c'
c9309e4
Merge commit '85de95211b9e0d72325c8dbfcbfe98a0bb78a2f8'
c55f263
Merge commit 'e6b0f6ddf41201fcbef84e458cd5e1c6d03f3e31'
03db418
@mmitche
Merged PR 45620: Update DIA to 17.12.0-beta1.24603.5
89ef51c 
Update DIA to 17.12.0-beta1.24603.5

----
#### AI description  (iteration 1)
#### PR Classification
Version update

#### PR Summary
This pull request updates the version of MicrosoftDiaSymReaderNative to 17.12.0-beta1.24603.5.
- `eng/Versions.props`: Updated `MicrosoftDiaSymReaderNativeVersion` to 17.12.0-beta1.24603.5.
@vseanreesermsft
Merge commit '89ef51c5d8f5239345127a1e282e11036e590c8b' into internal…
0f5d4d6 
…-merge-8.0-2025-01-14-1047
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 14, 2025
carlossanlop
carlossanlop approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MERGE COMMIT

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-codeflow for labeling automated codeflow and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 14, 2025
@carlossanlop
Copy link
Member

@hoyosjs this failure is related to one of the commits in this PR:

src/coreclr/tools/r2rdump/R2RDump.csproj(0,0): error NU1102: Unable to find package Microsoft.DiaSymReader.Native with version (>= 17.12.0-beta1.24603.5) - Found 27 version(s) in dotnet-public [ Nearest version: 17.10.0-beta1.24272.1 ] - Found 5 version(s) in dotnet-tools [ Nearest version: 16.9.0-beta1.21117.1 ] - Found 0 version(s) in darc-pub-dotnet-emsdk-c458a76-1 - Found 0 version(s) in darc-pub-dotnet-emsdk-c458a76-2 - Found 0 version(s) in darc-pub-dotnet-emsdk-c458a76-3 - Found 0 version(s) in darc-pub-dotnet-emsdk-c458a76 - Found 0 version(s) in dotnet-eng - Found 0 version(s) in dotnet-libraries-transport - Found 0 version(s) in dotnet-libraries - Found 0 version(s) in dotnet8-transport - Found 0 version(s) in dotnet8

@hoyosjs
Copy link
Member

hoyosjs commented Jan 15, 2025

We need to add the package to NuGet from our internal feeds.

@carlossanlop
Copy link
Member

/ba-g The Microsoft.DiaSymReader packages have been pushed to the necessary feeds.

@carlossanlop carlossanlop merged commit 0205d7b into dotnet:release/8.0 Jan 15, 2025
42 of 148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees

@vseanreesermsft vseanreesermsft

Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vseanreesermsft @carlossanlop @hoyosjs