Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broken Build]: What changed between 17.10.4 to 17.12.6? Our build is broken. #11019

Open
nbevans opened this issue Nov 21, 2024 · 3 comments
Open
Assignees
Labels
needs-more-info Issues that need more info to continue investigation. stale For issues that haven't had activity in some time. triaged

Comments

@nbevans
Copy link

nbevans commented Nov 21, 2024

Issue Description

We have a F# solution which is a mixture of net48, netstandard20 and some WebSharper 4.x projects. After installing VS 17.12 update this week, our team can no longer build the WebSharper projects. If we use the slightly older VS Build Tools LTSC 17.10.4 to run the build, the issue goes away.

Steps to Reproduce

The WebSharper (WsFsc) tool can no longer "see" the <ProjectReference>'s and thinks all the namespaces/modules/types in those assemblies are missing. The actual F#/FSC compilation itself is successful.

If I replace the SDK-style 's with the very old style of:

<Reference Include="MyProject">
	<HintPath>bin\Debug\MyProject.dll</HintPath>
	<Private>True</Private>
</Reference>

.. then the issue goes away - albeit then breaks other stuff in WebSharper's compiler but that seems unrelated to the initial problem.

It looks like this new version of MSBuild has broken something with older toolchains?

I've attached a binlog (.txt to get around file restriction)

sg.binlog.txt

Expected Behavior

<ProjectReference> should behave the same way it did on 17.10.4 when dealing with older toolchains.

Actual Behavior

When using MSBuild 17.12.6 the <ProjectReference>'s are not properly understood by WsFsc (WebSharper 4.x) post-compilation step. This is the step that converts F# code into JavaScript (if that's relevant).

Ask us questions

No response

@nbevans
Copy link
Author

nbevans commented Nov 22, 2024

Reading through this https://github.com/dotnet/msbuild/blob/main/documentation/ProjectReference-Protocol.md - there could be any number of things here relating to this issue - certainly ProjectReference has had a number of changes made to it in recently MSBuild versions. Maybe some of the dynamic platform/targeting stuff is the root cause.

@maridematte
Copy link
Contributor

Would you have a small repo project? It might be the easiest way for investigation. For sending binlogs, we suggest you open a ticket through report a problem through Visual Studio, as binlogs have a lot of personal information from your setup.

@maridematte maridematte self-assigned this Dec 3, 2024
@maridematte maridematte added needs-more-info Issues that need more info to continue investigation. triaged labels Dec 3, 2024
Copy link
Contributor

This issue is marked as stale because feedback has been requested for 30 days with no response. Please respond within 14 days or this issue will be closed due to inactivity.

@dotnet-policy-service dotnet-policy-service bot added the stale For issues that haven't had activity in some time. label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info Issues that need more info to continue investigation. stale For issues that haven't had activity in some time. triaged
Projects
None yet
Development

No branches or pull requests

2 participants