Skip to content

dotnet build doesn't relink iOS native frameworks when packages are added/removed #21223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bnickel opened this issue Sep 11, 2024 · 1 comment · Fixed by #22911
Closed

dotnet build doesn't relink iOS native frameworks when packages are added/removed #21223

bnickel opened this issue Sep 11, 2024 · 1 comment · Fixed by #22911
Assignees
@rolfbjarne
Labels
bug If an issue is a bug or a pull request a bug fix
Milestone
.NET 10

Comments

@bnickel
Copy link

bnickel commented Sep 11, 2024

Apple platform

iOS

Framework version

net8.0-*

Affected platform version

.Net 8.0.401, Maui 8.0.82/8.0.100

Description

I have a NuGet package that includes XCFrameworks and observed a NullReferenceException when I first tried to integrate it into an app. I identified the issue as the frameworks not being linked in the native binary (i.e., they don't appear when calling otool -L AppName.app/AppName). Cleaning and rebuilding fixes the issue, but it's a kind of change I'd expect to be automatically picked up.

Steps to Reproduce

mkdir MyApp
cd MyApp
dotnet new maui
dotnet build -p:TargetFramework=net8.0-ios
otool -L ./bin/Debug/net8.0-ios/iossimulator-arm64/MyApp.app/MyApp | grep rpath
# ✅ zero lines, as expected

dotnet add MyApp.csproj package HeapInc.Maui
dotnet build -p:TargetFramework=net8.0-ios
otool -L ./bin/Debug/net8.0-ios/iossimulator-arm64/MyApp.app/MyApp | grep rpath
# ❌ zero lines, unexpected

dotnet clean
dotnet build -p:TargetFramework=net8.0-ios
otool -L ./bin/Debug/net8.0-ios/iossimulator-arm64/MyApp.app/MyApp | grep rpath
#	@rpath/HeapSwiftCore-Dynamic.framework/HeapSwiftCore-Dynamic (compatibility version 0.0.0, current version 0.0.0)
#	@rpath/HeapSwiftCoreInterfaces.framework/HeapSwiftCoreInterfaces (compatibility version 1.0.0, current version 1.0.0)
# ✅ Frameworks from HeapInc.Maui

dotnet remove MyApp.csproj package HeapInc.Maui

dotnet build -p:TargetFramework=net8.0-ios
otool -L ./bin/Debug/net8.0-ios/iossimulator-arm64/MyApp.app/MyApp | grep rpath
#	@rpath/HeapSwiftCore-Dynamic.framework/HeapSwiftCore-Dynamic (compatibility version 0.0.0, current version 0.0.0)
#	@rpath/HeapSwiftCoreInterfaces.framework/HeapSwiftCoreInterfaces (compatibility version 1.0.0, current version 1.0.0)
# ❌ Frameworks should have been removed

dotnet clean
dotnet build -p:TargetFramework=net8.0-ios
otool -L ./bin/Debug/net8.0-ios/iossimulator-arm64/MyApp.app/MyApp | grep rpath
# ✅ zero lines, as expected

Did you find any workaround?

Running dotnet clean after dotnet add and dotnet remove.

Relevant logs

No response
@rolfbjarne
Copy link
Member

I can reproduce this.

Here's a build log showing the problem:
msbuild.binlog.zip

Skipping target "_LinkNativeExecutable" because all output files are up-to-date with respect to the input files.

@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Sep 12, 2024
@rolfbjarne rolfbjarne added this to the .NET 10 milestone Sep 12, 2024
@rolfbjarne rolfbjarne self-assigned this May 26, 2025
rolfbjarne added a commit that referenced this issue May 27, 2025
@rolfbjarne
[dotnet] Fix dependency tracking for trimming and native linking. Fixes
4d2ff61 
#21223.

Store the non-file inputs to the trimmer and native linker in cache files, and if
these inputs change, then rerun the trimmer and native linker. This is implemented
by computing a hash of all these inputs (properties), store the hash to a file, and
overwrite the file if the hash changes. Then in a subsequent target, we force the
trimmer or native linekr to run if the file with the hash value changed.

This is a similar implementation of how the csc task (C# compiler) creates a hash
of the compiler input in order to know when to re-execute the C# compiler.

Also fix a bug in the Codesign task, where the task would always resign an app bundle
if it contained something inside that needed to be signed separately (it wouldn't
consider that the contained something could already be signed).

Fixes #21223.
@rolfbjarne rolfbjarne mentioned this issue May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolfbjarne rolfbjarne

Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Milestone
.NET 10
Development

Successfully merging a pull request may close this issue.

[dotnet] Fix dependency tracking for trimming and native linking. Fixes #21223. dotnet/macios
2 participants
@rolfbjarne @bnickel