Repository navigation
Transparent compiler should recheck dependent files when an evicted upstream file result is recomputed - #20643
Open
michaelglass wants to merge 2 commits into
Open
michaelglass wants to merge 2 commits into
michaelglass wants to merge 2 commits into
Conversation
Contributor
✅ Release notes checked
|
michaelglass
added a commit
to michaelglass/fsharp
that referenced
this pull request
Sep 26, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
🔍 Tooling Safety Check — Affects-Design-Time
|
T-Gro
self-requested a review
September 29, 2026 09:33
Member
|
@copilot resolve the merge conflicts in this pull request |
T-Gro
approved these changes
Oct 9, 2026
Contributor
Author
|
for these types of release note conflicts, I shouldn't resolve them myself right? (because it'll dismiss the existing AI review?) |
2 of 3 tasks
Member
|
Ideally use the skill to avoid them. If not, then please do resolve - if I resolve it and I am the latest pusher, my approval will no longer count. |
T-Gro
approved these changes
Oct 13, 2026
michaelglass
added a commit
to michaelglass/fsharp
that referenced
this pull request
Oct 15, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
michaelglass
force-pushed
the
fix-tc-intermediate-cache-identity
branch
from
October 15, 2026 08:57
74a5345 to
4dddeae
Compare
Contributor
Author
T-Gro
approved these changes
Oct 19, 2026
T-Gro
enabled auto-merge (squash)
October 19, 2026 13:31
…they used The cached type-check result of a file was keyed by the source up to that file, not by the results of the earlier files it was checked against. When an earlier file's result was garbage collected and recomputed, it declared new entities, while cached results of later files still referred to the old ones. Checking a file that combined both reported errors like "This expression was expected to have type 'A.T' but here has type 'A.T'". Each computed result now gets a unique id, the state passed to a file records the ids of the results it was built from, and those ids are part of the file's cache key, so results that depend on a recomputed one are recomputed too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
auto-merge was automatically disabled
October 22, 2026 10:21
Head branch was pushed to by a user without write access
michaelglass
force-pushed
the
fix-tc-intermediate-cache-identity
branch
from
October 22, 2026 10:21
4dddeae to
dc71aa5
Compare
Contributor
Author
|
@T-Gro I forced pushed to resolve the merge conflict |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this PR
Checking A again declares a new copy of
T, while B's cached result still refers to the old copy.After this PR
Regression test:
Recomputing a collected upstream file result does not mix it with cached downstream resultsintests/FSharp.Compiler.ComponentTests/FSharpChecker/TransparentCompiler.fs.Related: #20644 fixes a separate
AsyncMemoizerace that can also leave two copies of a file's types in use. The fixes are independent; either can merge first.Written with Claude Code (Opus 5.5).
Checklist