Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill xml on s3 api #751

Open
2 tasks
prisamuel opened this issue Sep 11, 2019 · 0 comments
Open
2 tasks

Kill xml on s3 api #751

prisamuel opened this issue Sep 11, 2019 · 0 comments
Labels
debt importance:medium urgency:medium

Comments

@prisamuel
Copy link
Contributor

prisamuel commented Sep 11, 2019 •
edited by Godley
Loading

User requirement

We should move our xml-based s3 api to use json as this is a built-in easily-implementable thing in golang, while xml parsing in react requires bundling a huge extra library.

  • Change the s3 api response to be json rather than xml
  • Change the frontend to just load in a json object from string as it does everywhere else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt importance:medium urgency:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prisamuel @alaric-dotmesh