Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing timeout on request #9

Closed
fhempy opened this issue Mar 28, 2018 · 2 comments
Closed

Missing timeout on request #9

fhempy opened this issue Mar 28, 2018 · 2 comments

Comments

@fhempy
Copy link

fhempy commented Mar 28, 2018

Hi,

is there a reason why timeout is not used in following line:

python-fhem/fhem/fhem/__init__.py

Line 261 in 4faea79

ans = urlopen(ccmd, paramdata) # , data, 10) # XXX timeout

Unfortunately I have sometimes connections errors and this line causes an infinite wait.
@domschl
Copy link
Owner

domschl commented Mar 29, 2018

There was an issue with different behaviour with Py2 and Py3. I found some useful information on this, so with next version, I will retest timeouts.

domschl added a commit that referenced this issue Dec 16, 2018
@domschl
Fix for missing timeout on send, #9
9b38fb4
@domschl
Copy link
Owner

domschl commented Dec 16, 2018

should be fixed in upcoming 0.6.0

@domschl domschl mentioned this issue Dec 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domschl @fhempy