Skip to content

Commit 38c3589

Browse files
committed
Rearrange tests
1 parent 83c88fc commit 38c3589

File tree

2 files changed

+46
-47
lines changed

2 files changed

+46
-47
lines changed

tests/test_integration/test_command.py

-34
This file was deleted.

tests/test_integration/test_config.py

+46-13
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,15 @@
44
import textwrap
55
import toml
66

7-
from tests.lib.util import get_version, get_version_setup_py, create_file, create_pyproject_toml, create_setup_py
7+
from tests.lib.util import (
8+
get_version,
9+
get_version_setup_py,
10+
get_version_script,
11+
get_version_module,
12+
create_file,
13+
create_pyproject_toml,
14+
create_setup_py,
15+
)
816

917
pytestmark = [pytest.mark.all, pytest.mark.important]
1018

@@ -61,16 +69,6 @@ def test_config_not_used(repo):
6169
assert get_version(repo, isolated=True) == "0.0.0"
6270

6371

64-
@pytest.mark.parametrize(
65-
"option",
66-
["version_config", "setuptools_git_versioning"],
67-
)
68-
def test_config_enabled_false(repo, create_config, option):
69-
create_config(repo, {"enabled": False}, option=option)
70-
71-
assert get_version(repo) == "0.0.0"
72-
73-
7472
@pytest.mark.parametrize(
7573
"value",
7674
[True, False],
@@ -81,6 +79,12 @@ def test_config_bool_pyproject_toml(repo, value):
8179
with pytest.raises(subprocess.CalledProcessError):
8280
get_version(repo)
8381

82+
with pytest.raises(subprocess.CalledProcessError):
83+
get_version_module(repo)
84+
85+
with pytest.raises(subprocess.CalledProcessError):
86+
get_version_script(repo)
87+
8488

8589
@pytest.mark.parametrize(
8690
"option",
@@ -97,9 +101,9 @@ def test_config_false_setup_py(repo, option):
97101
["version_config", "setuptools_git_versioning"],
98102
)
99103
def test_config_true_setup_py(repo, option):
100-
create_setup_py(repo, False, option=option)
104+
create_setup_py(repo, True, option=option)
101105

102-
assert get_version_setup_py(repo) == "0.0.0"
106+
assert get_version_setup_py(repo) == "0.0.1"
103107

104108

105109
@pytest.mark.parametrize(
@@ -134,6 +138,13 @@ def test_config_both_setup_py_and_pyproject_toml(repo, option):
134138
with pytest.raises(subprocess.CalledProcessError):
135139
get_version(repo)
136140

141+
# python -m setuptools_git_versioning
142+
# and
143+
# setuptools_git_versioning
144+
# are not using setup.py, so they are not raising any errors
145+
assert get_version_script(repo) == "0.0.1"
146+
assert get_version_module(repo) == "0.0.1"
147+
137148

138149
@pytest.mark.parametrize(
139150
"option",
@@ -144,6 +155,8 @@ def test_config_pyproject_toml_is_used_then_setup_py_is_empty(repo, option):
144155
create_setup_py(repo, NotImplemented, option=option, add=False, commit=False)
145156

146157
assert get_version(repo) == "2.3.4"
158+
assert get_version_script(repo) == "2.3.4"
159+
assert get_version_module(repo) == "2.3.4"
147160

148161

149162
def test_config_pyproject_toml_is_used_then_setup_py_does_not_exist(repo):
@@ -160,6 +173,8 @@ def test_config_pyproject_toml_is_used_then_setup_py_does_not_exist(repo):
160173
)
161174

162175
assert get_version(repo) == "2.3.4"
176+
assert get_version_script(repo) == "2.3.4"
177+
assert get_version_module(repo) == "2.3.4"
163178

164179

165180
def test_config_setup_py_is_used_then_pyproject_toml_is_empty(repo):
@@ -168,12 +183,24 @@ def test_config_setup_py_is_used_then_pyproject_toml_is_empty(repo):
168183

169184
assert get_version(repo) == "2.3.4"
170185

186+
with pytest.raises(subprocess.CalledProcessError):
187+
get_version_module(repo)
188+
189+
with pytest.raises(subprocess.CalledProcessError):
190+
get_version_script(repo)
191+
171192

172193
def test_config_setup_py_is_used_then_pyproject_toml_does_not_exist(repo):
173194
create_setup_py(repo, {"starting_version": "2.3.4"}, add=False, commit=False)
174195

175196
assert get_version_setup_py(repo) == "2.3.4"
176197

198+
with pytest.raises(subprocess.CalledProcessError):
199+
get_version_module(repo)
200+
201+
with pytest.raises(subprocess.CalledProcessError):
202+
get_version_script(repo)
203+
177204

178205
@pytest.mark.parametrize(
179206
"version_config, setuptools_git_versioning",
@@ -221,3 +248,9 @@ def test_config_both_old_and_new_config_are_set(repo, version_config, setuptools
221248

222249
with pytest.raises(subprocess.CalledProcessError):
223250
get_version(repo)
251+
252+
with pytest.raises(subprocess.CalledProcessError):
253+
get_version_module(repo)
254+
255+
with pytest.raises(subprocess.CalledProcessError):
256+
get_version_script(repo)

0 commit comments

Comments
 (0)