Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1655 - Typeahead / Select Placeholder #1718

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

1655 - Typeahead / Select Placeholder #1718

wants to merge 11 commits into from

Conversation

KaneFreeman
Copy link
Member

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:
Add placeholder input for typeahead and select, add default option when required is false

Resolves #1655

@vercel
Copy link

vercel bot commented Apr 6, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/3XessanKdWC9EC1y6gi7LANtmpuQ
✅ Preview: https://widget-test-do-git-fork-kanefreeman-bugfix-select-typeah-369d97.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/ABmYkjdDGRxiV2MfL6TC5NngLBxn
✅ Preview: https://dojowidgets-git-fork-kanefreeman-bugfix-select-typeah-0d8289.vercel.app

@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.75362% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.53%. Comparing base (d543a3f) to head (5c1bd28).
Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
src/typeahead/index.tsx 88.88% 0 Missing and 3 partials ⚠️
src/select/index.tsx 91.30% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1718      +/-   ##
==========================================
+ Coverage   90.43%   90.53%   +0.09%     
==========================================
  Files          94       94              
  Lines        5143     5175      +32     
  Branches     1403     1415      +12     
==========================================
+ Hits         4651     4685      +34     
+ Misses        241      237       -4     
- Partials      251      253       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agubler agubler removed their request for review May 22, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomdye tomdye Awaiting requested review from tomdye

@matt-gadd matt-gadd Awaiting requested review from matt-gadd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typeahead widget does not trigger onValue event when user clears the field (no selection)
1 participant
@KaneFreeman