-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel not working while motion
is disabled on the device
#610
Comments
Hey @BrodaNoel! Nice to see you back and diving into the depths of animations with us. 🎢 I remember our last adventure here. I'll be taking a look at this motion-related conundrum you've unearthed and will circle back with a full answer shortly. Hang tight! |
Seems like there are some "1 line" fixes here: https://docs.swmansion.com/react-native-reanimated/docs/guides/accessibility/ |
Good find! It seems that standard iOS carousels still function as animated (sliding) carousels even with "Reduce motion" enabled. (For example, swiping between home screens of icons still animates; swiping between photos in the standard Photos app still animates.) IMO, to follow this paradigm, react-native-reanimated-carousel should also still function as normal-- even with "Reduce motion" enabled. |
To address the issue with
By following these steps, you can enhance the accessibility and user experience of your application for users who have "Reduce Motion" enabled, ensuring that the carousel functions correctly and animations do not end prematurely.
|
News on this? |
^ the solution posted here does fix it |
Today I upgraded to SDK 51 and I got a Warning from
[Reanimate]
who says: "Some animations may be disabled because your phone disabled animations"Well... In my iPhone, I went to
Settings > Accesibility > Motion
, and I've found that I disabled it in order to avoid wasting battery.I enabled animations, and most of the issues dissapeared, like #604 and #590 (and probably A LOT of other issues).
So, what happens, is that when the iPhone has motion disabled, the animations ends automatically, so, some times, they move from "20%" (animation progress) to "100%", which will end up breaking the
computedRealIndexWithAutoFillData
function, because thecomputedRealIndexWithAutoFillData
gets called before it realized that the animation reached "100%", thus, we get a wrong value.Consider taking a look at this condition, because it may be the reason of a lot of bugs.
The text was updated successfully, but these errors were encountered: