Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing installation steps for the web when using react-native-gesture-handler >= 2.10.0 #542

Open
cglacet opened this issue Feb 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@cglacet
Copy link

cglacet commented Feb 6, 2024

Describe the bug

Missing installation steps for react-native-gesture-handler >=2.10.0 for the web.

Fix

Include something like the following in the installation steps for the web:

If you have react-native-gesture-handler >= 2.10.0 installed, you will need to use the legacy gesture handler, this can be done by editing your web app entry point:

import { enableLegacyWebImplementation } from 'react-native-gesture-handler';

enableLegacyWebImplementation(true);

More information about the legacy implementation here Install react native gesture handler: Web

To Reproduce

Install the latest version of react-native-gesture-handler, create a Carousel and try to swipe on a touch screen. This will make items disapear.

Expected behavior

Touch events working on the web for all versions of react-native-gesture-handler.

Versions (please complete the following information):

  • react: v18.2
  • react-native: v0.72.6
  • react-native-reanimated: v3.4.2
  • react-native-reanimated-carousel: v3.5.1
  • react-native-gesture-handler: v2.15.0

Smartphone (please complete the following information):

  • Device: desktop
  • Browser: Chrome (debug mobile view)
  • Version: 121.0.6167.140
@cglacet cglacet added the bug Something isn't working label Feb 6, 2024
Copy link

dosubot bot commented Feb 6, 2024

🤖

Thank you for bringing this to our attention! Your proposed fix looks great and would definitely help improve the installation steps for react-native-gesture-handler on the web. We appreciate your contribution and encourage you to create a pull request with your suggested changes. Your effort will help make the installation process smoother for other users. Keep up the good work!


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added the documentation Improvements or additions to documentation label Feb 6, 2024
@tomashco
Copy link

that solved my issue installing react-native-reanimated-carousel on web! thank you!

Describe the bug

Missing installation steps for react-native-gesture-handler >=2.10.0 for the web.

Fix

Include something like the following in the installation steps for the web:

If you have react-native-gesture-handler >= 2.10.0 installed, you will need to use the legacy gesture handler, this can be done by editing your web app entry point:

import { enableLegacyWebImplementation } from 'react-native-gesture-handler';

enableLegacyWebImplementation(true);

More information about the legacy implementation here Install react native gesture handler: Web

To Reproduce

Install the latest version of react-native-gesture-handler, create a Carousel and try to swipe on a touch screen. This will make items disapear.

Expected behavior

Touch events working on the web for all versions of react-native-gesture-handler.

Versions (please complete the following information):

* react: v18.2

* react-native: v0.72.6

* react-native-reanimated: v3.4.2

* react-native-reanimated-carousel: v3.5.1

* react-native-gesture-handler: v2.15.0

Smartphone (please complete the following information):

* Device: desktop

* Browser: Chrome (debug mobile view)

* Version: 121.0.6167.140

@nikenvy
Copy link

nikenvy commented Feb 19, 2024

helped me too on expo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants