-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to get on the official WordPress oEmbed whitelist #15
Comments
I think this is worth doing, but I don't think it would make the plugin obsolete. You might still want to pass in viewer configuration on a per-document basis. We could also implement oembed-style embedding via this plugin, like Storify does. |
@eyeseast we're implementing an oEmbed endpoint right now, and were planning on kicking around this wordpress plugin as our test consumer. What's Storify do regarding oEmbed? :) |
@eyeseast That's totally true, we'd discussed that internally and I'd forgotten that. There's definitely still room for a more advanced plugin even after whitelisting. |
See point 3 here: https://wordpress.org/plugins/storify/faq/. You just include a link on its own line, like so:
The storify link will get turned into an embed code. |
The storify plugin might be a pretty good reference actually if you're not familiar with how WP handles some of this stuff (or, is able to handle some of this stuff) from the theme/plugin side |
Hi guys. Sorry to cut in, I monitor "oEmbed" topic here on GitHub. I am one of the guys behind Iframely and we'd be happy to be your test oEmbed consumer. And actually work with you as I am sure you will run into document height issues. What Storify does as embed code is that they give iframe of 750 height and also include javascript that adjusts the height onload through window.postMessage. https://github.com/davidjbradshaw/iframe-resizer - if you'd rather not implement it yourself. Here's to help you debug your oEmbed: http://iframely.com/debug/ We have a bunch of other tools so you could see your oEmbeds in a variety of ways. Let me know. |
Steps to getting here:
|
Were you ever able to get this going? What was the process for getting whitelisted w/ wordpress? I may be implementing something similar, and would love to be whitelisted. |
Hey @TheRoccoB, we haven't pursued whitelisting further with wordpress.com. We do know that the plugin's gotten a review for Wordpress VIP, but that was handled at the level of our users asking their VIP teams to investigate. |
Got it. Sounds like you have to be reasonably established for them to whitelist you. Thanks for letting me know! |
See https://codex.wordpress.org/Embeds#Okay.2C_So_What_Sites_Can_I_Embed_From.3F
If we were whitelisted, then this plugin would be unnecessary in the simplest cases (and except to support older versions of WP).
So this issue is also the "obsolete this plugin" issue.Edited to remove obsoleting language, as this would still be useful even after whitelisting.
The text was updated successfully, but these errors were encountered: