'module' object has on attribute 'connection'

[vangie]

run on ubuntu 3.19.0-23-generic #24~14.04.1-Ubuntu
docker-py version 1.8.1 and 1.8.0 failed, but version 1.7.0，1.7.2 is OK.

root@ide-staging-01:~# pip freeze | grep docker-py && python --version && docker version
docker-py==1.8.1
Python 2.7.6
Client:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Tue Apr 26 23:30:23 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Tue Apr 26 23:30:23 2016
 OS/Arch:      linux/amd64

root@ide-staging-01:~# uname -a
Linux ide-staging-01 3.19.0-23-generic #24~14.04.1-Ubuntu SMP Wed Jul 8 11:15:13 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
root@ide-staging-01:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04.2 LTS
Release:    14.04
Codename:   trusty

root@ide-staging-01:~# python
Python 2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from docker import Client
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/docker/__init__.py", line 20, in <module>
    from .client import Client, AutoVersionClient, from_env # flake8: noqa
  File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 25, in <module>
    from . import api
  File "/usr/local/lib/python2.7/dist-packages/docker/api/__init__.py", line 2, in <module>
    from .build import BuildApiMixin
  File "/usr/local/lib/python2.7/dist-packages/docker/api/build.py", line 9, in <module>
    from .. import utils
  File "/usr/local/lib/python2.7/dist-packages/docker/utils/__init__.py", line 1, in <module>
    from .utils import (
  File "/usr/local/lib/python2.7/dist-packages/docker/utils/utils.py", line 33, in <module>
    from .. import tls
  File "/usr/local/lib/python2.7/dist-packages/docker/tls.py", line 5, in <module>
    from .ssladapter import ssladapter
  File "/usr/local/lib/python2.7/dist-packages/docker/ssladapter/__init__.py", line 1, in <module>
    from .ssladapter import SSLAdapter # flake8: noqa
  File "/usr/local/lib/python2.7/dist-packages/docker/ssladapter/ssladapter.py", line 22, in <module>
    urllib3.connection.match_hostname = match_hostname
AttributeError: 'module' object has no attribute 'connection'
>>>

[shin-]

I need more information. Please follow the instructions for reporting issues

[vangie]

@shin- I have updated environment information.

[TomasTomecek]

This could be a very old version of urllib3. Share the version please:

$ pip freeze | grep -e urllib3 -e requests

It could also be interesting to see if urllib3 (and requests) comes from distribution or from PyPI.

[vangie]

root@ide-staging-01:~# pip freeze | grep -e urllib3 -e requests
requests==2.7.0
urllib3==1.7.1

[vangie]

root@ide-staging-01:~# dpkg -l | grep urllib3
ii  python-urllib3                        1.7.1-1ubuntu3                        all          HTTP library with thread-safe connection pooling for Python
ii  python-urllib3-whl                    1.7.1-1ubuntu3                        all          HTTP library with thread-safe connection pooling
root@ide-staging-01:~# dpkg -l | grep request
ii  iputils-arping                        3:20121221-4ubuntu1.1                 amd64        Tool to send ICMP echo requests to an ARP address
ii  python-requests                       2.2.1-1ubuntu0.3                      all          elegant and simple HTTP library for Python, built for human beings
ii  python-requests-whl                   2.2.1-1ubuntu0.3                      all          elegant and simple HTTP library for Python, built for human beings

Noticed the same issue on my side.
I was setting up some Docker containers through ansible.
System information:
OS/Distrib: Linux / Ubuntu14.04
Python version: 2.7
docker-py version: 1.8.1
docker version: 1.11.1

After careful investigation, I noticed a few things:

1. requests module was present, and looked like it matched the expectations of docker-py
2. No module could be imported from within docker-py
3. docker-py thus fallbacked onto urllib3 rather than requests.packages.urllib3
4. urllib3 somehow did not provide the same API than my version of requests.packages.urllib3

Digging more into it, I found out the following:

1. https://github.com/kennethreitz/requests/blob/master/requests/packages/__init__.py#L14 : See the quote: requests.packages.urllib3 is not urllib3.
   I think they attempt to imply that both should not be seen as equivalent. As such, the following lines were surprising to me, but from reading the comments on this PR, this may be intended for a recent urllib3 version: https://github.com/docker/docker-py/blob/master/docker/ssladapter/ssladapter.py#L13. Does it deserve an improvement ?
2. Changing the ordering of the paths in PYTHONPATH seemed to fix the issue or resolution of requests.packages.urllib3, thus fixing docker-py
   It looked like on the machine having this issue, some manual install/removal somehow changed the order of the paths in PYTHONPATH, so that /usr/local/lib/python2.7/dist-packages was coming later in the list than /usr/lib/python2.7/dist-packages.
   The effect was that importing something within requests suche as requests.packages yielded a no such module error.
   Inverting the order of the two paths previously quoted seemed to solve the issue (we did that globally through the file /etc/environment)

I do not know how our machine came to this situation, and I couldn't find out more than this in the time I spent investigating.

[shin-]

I believe that happens because requests in Ubuntu can't vendor in urllib3 (see here), so we had to construct a fallback that uses the version installed on the system instead.

Because the version of urllib3 that's available on Trusty is so old, docker-py's attempt at monkey-patching it is unfortunately failing. Installing a more recent version of urllib3 using pip may solve the issue. (pip install -U urllib3==1.14)

I'll try and figure out if there's a better solution for us.

@shin- Thanks for being reactive on this subject.
I do not know which urllib3 version I was using, but it is probably older, as you pointed out.
That being said, I'll take anything that does not involve tweaking my environment variables to get requests.packages.urllib3 to be importable when it is present in the system's directories.

[dan-petty]

I'm getting this error with:
docker 1.11.1
docker-py 1.8.1
urllib3 1.15.1

Works with:
docker 1.11.1
docker-py 1.7.2
urllib3 1.15.1

[shin-]

@mixmatch What about docker-py==1.8.1 + urllib3==1.14 ?

[shin-]

Also, what OS/version are you using?

[rpinohtyp]

this fixed it for me
$ cat /etc/environment .bash_profile .profile | grep python2.7 PYTHONPATH="/usr/local/lib/python2.7/dist-packages:/usr/lib/python2.7/dist-packages"
with:
$ lsb_release -a
No LSB modules are available.
Distributor ID: LinuxMint
Description: Linux Mint 17.3 Rosa
Release: 17.3
Codename: rosa

thx @DavidPineauScality