Switch from distutils to setuptools #12259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuznet
added
Python3
Technical Debt
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
vkuznet
force-pushed
the
disutils2setuptools
branch
from
c38ee4f to
f1e5c63
Compare
|
Jenkins results:
|
vkuznet
force-pushed
the
disutils2setuptools
branch
2 times, most recently
from
fa79dbb to
874d394
Compare
|
Jenkins results:
|
|
Jenkins results:
|
vkuznet
force-pushed
the
disutils2setuptools
branch
from
874d394 to
5becac3
Compare
|
Jenkins results:
|
vkuznet
force-pushed
the
disutils2setuptools
branch
from
5becac3 to
576e325
Compare
|
Jenkins results:
|
|
@amaltaro , @todor-ivanov , @mapellidario I asked you to review this PR and I want to let you know that I identified that we have |
|
@vkuznet if you couldn't find any reference to it, my suggestion is to make a new commit deleting it and making an explicit note in the initial PR description that it is being deleted because it is unused. |
ok, removed and adjusted the description. |
|
Jenkins results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12256
Status
in development
Description
Provide switch from
distutilstosetuptoolslibrary for all scripts and tools used by WMCore code-base. This PR provides the following:.github/workflows/build_and_install_locally.yamlnew CI/CD workflow to locally build and install WM packagesbin/test_local_build_and_install.shscript which imitates CI/CD workflow and relies on virtual environment to build and install WM packages locallysetup.pyscript can be used to build wmcore package, e.g.python setup.py sdistsetup_template.pyscript is used by CI/CD workflows to build concrete WM package, e.g. reqmgr2.github/workflows/pypi_build_and_images.yaml) copiessetup_tempate.pyintosetup.pyand properly setup package namerequirements.txtpython3 setup.py clean sdistto create distribution tar ball.NOTE 1: the WM build steps run within CI/CD pipeline as a matrix and therefore overwritten
setup.pyandrequirements.txtfiles never cause any problems, i.e. they are within separate docker images during CI/CD execution, i.e. within specific matrix build.NOTE 2:
The provided
bin/test_local_build_and_install.shscript only build and install WM packages in local virtual environment. It does not verifies their functionality though as it requires additional setup like databases, htcondor, gfal libraries.It also install all WM packages within single virtual environment. Another approach would be use individual virtual environment areas for individual WM packages, and if it will be desired I can provide a new script or modify
bin/test_local_build_and_install.shaccordingly. The issue with multiple virtual environments that it waste disk space as WM packages share dependencies among each other. Therefore, I opted with single virtual environment approach.Local builds and installation skips
htcondorandgfaldependencies as they are very centric for CERN based Linux OS. All other dependencies are OS agnostic and presented in local build/install procedure which can be performed on any Linux, and macOS versions.NOTE 3: I removed
setup_wmcore.pyfrom the repository in this commit since I was unable to find out usage of this code anywhere in WMCore repository.Is it backward compatible (if not, which system it affects?)
Most likely YES, but I'm not 100% sure.
I performed local installation and compared tarballs using distutils and setuptools, but no actual tests were done with individual packages as it requires their upload to PyPi and installation elsewhere.
Related PRs
External dependencies / deployment changes