[CI] Move some CI linting jobs to pre-commit (#11953)

Author: RAMitchell

.github/workflows/lint.yml

@@ -51,22 +51,3 @@ jobs:
         shell: bash -el {0}
         run: |
           python ops/script/lint_python.py --format=0 --type-check=0 --pylint=1
-
-  cpp-lint:
-    runs-on: ubuntu-latest
-    name: Code linting for C++
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          submodules: 'true'
-      - uses: actions/setup-python@v5
-        with:
-          python-version: "3.10"
-          architecture: 'x64'
-      - name: Install Python packages
-        run: |
-          python -m pip install wheel setuptools cmakelint cpplint==1.6.1 pylint
-      - name: Run lint
-        run: |
-          python3 ops/script/lint_cpp.py
-          bash ops/script/lint_cmake.sh

.github/workflows/pre-commit.yml

@@ -7,9 +7,8 @@ permissions:
 
 jobs:
   pre-commit:
-    name: Run pre-commit (non-blocking)
+    name: Run pre-commit
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - uses: actions/checkout@v4
         with:

.pre-commit-config.yaml

@@ -12,3 +12,23 @@ repos:
       - id: check-executables-have-shebangs
       - id: check-shebang-scripts-are-executable
       - id: mixed-line-ending
+  - repo: local
+    hooks:
+      - id: lint-cpp
+        name: C++ lint (cpplint)
+        entry: python ops/script/lint_cpp.py
+        language: python
+        types: [file]
+        files: \.(cc|c|cpp|h|cu|hpp)$
+        exclude: (dmlc-core|gputreeshap)
+        additional_dependencies:
+          - cpplint==1.6.1
+      - id: lint-cmake
+        name: CMake lint (cmakelint)
+        entry: cmakelint --linelength=120 --filter=-convention/filename,-package/stdargs,-readability/wonkycase
+        language: python
+        types: [file]
+        files: (CMakeLists\.txt$|^cmake/.*\.cmake$)
+        exclude: (dmlc-core|gputreeshap)
+        additional_dependencies:
+          - cmakelint

doc/contrib/coding_guide.rst

@@ -116,10 +116,11 @@ Running Formatting Checks Locally
 Once you submit a pull request to `dmlc/xgboost <https://github.com/dmlc/xgboost>`_, we perform
 two automatic checks to enforce coding style conventions. To expedite the code review process, you are encouraged to run the checks locally on your machine prior to submitting your pull request.
 
-Pre-commit (Optional)
-=====================
-We provide a minimal `pre-commit <https://pre-commit.com/>`_ configuration for basic whitespace
-and file-sanity checks. It only runs on changed files by default.
+Pre-commit
+==========
+We provide a `pre-commit <https://pre-commit.com/>`_ configuration for basic formatting and
+file-sanity checks. It only runs on changed files by default, and the same checks run in CI
+as a required (blocking) job.
 
 To enable it locally:
 
@@ -169,12 +170,6 @@ To run checks for cpplint locally:
   python ./ops/script/lint_cpp.py
 
 
-See next section for clang-tidy. For CMake scripts:
-
-.. code-block:: bash
-
-  bash ./ops/script/lint_cmake.sh
-
 Lastly, the linter for jvm-packages is integrated into the maven build process.