Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approximate image count off by 1 #927

Open
donaldgray opened this issue Dec 10, 2024 · 0 comments
Open

Approximate image count off by 1 #927

donaldgray opened this issue Dec 10, 2024 · 0 comments
Labels
API https://dlcs-book.readthedocs.io/en/latest/ bug Something isn't working engine

Comments

@donaldgray
Copy link
Member

donaldgray commented Dec 10, 2024

Issue #917 resolved an issue where new/empty spaces had an approximate count of 1, rather than 0.

However, this fix has resulted in all further approximageImageCount values being 1 less than expected. Possible resolution is to revert the fix for #917 and instead alter the space-creation logic.

Update: May be an issue with items being deleted from space, the first time images are added it seems to behave as expected. The issue arises when images have been cleared from space.

@donaldgray donaldgray added bug Something isn't working API https://dlcs-book.readthedocs.io/en/latest/ engine labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API https://dlcs-book.readthedocs.io/en/latest/ bug Something isn't working engine
Projects
None yet
Development

No branches or pull requests

1 participant