Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating to d3.v4 #27

Open
cyremur opened this issue Jun 12, 2017 · 2 comments
Open

Consider updating to d3.v4 #27

cyremur opened this issue Jun 12, 2017 · 2 comments

Comments

@cyremur
Copy link

cyremur commented Jun 12, 2017

I am using in this for a personal project in conjunction with typescript and d3.v4. I had to make some changes, mainly to incorporate the different naming convention used in v4. If you like, I could PR these updates back to your gantt-chart.

If you decide this is a valuable addition to your repo, please tell me how you would like to incorporate the changes (updating the old file, inserting a separate file for v4, etc.).

@cyremur cyremur changed the title Consider updatingUpdate to d3.v4 Consider updating to d3.v4 Jun 12, 2017
@SOSharkie
Copy link

@cyremur I am trying to incorporate this Gantt chart into a project with typescript as well, and I'm interested in how you achieved this, would you mind sharing?

@cyremur
Copy link
Author

cyremur commented Jul 2, 2017

@SOSharkie Have a look at this project: https://github.com/cyremur/InDiFront

I've rewritten the gantt js code in gantt-chart-d3.ts. Note that although it is working, it's not a perfect adaptation to typescript and probably breaks quite a few best practices I wasn't aware of since I only just started using typescript. Should give you a somewhat better starting point, though. You can also look at index.ts for some example code how to use the gantt-chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants