-
Notifications
You must be signed in to change notification settings - Fork 50
fix: add missing hook auto-initialization logic on startup #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Umupa
wants to merge
1
commit into
djyde:main
Choose a base branch
from
Umupa:fix/auto-add-notification-hooks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the startup logic only called update_claude_code_hook() which updates existing ccmate hooks but never adds them if missing. This caused notification features to silently fail for users without hooks configured, despite the UI showing notification settings. Changes: - Add check_claude_code_hooks_exist() to detect hook presence - Update startup logic to add hooks if missing, update if existing - Add fallback to ensure hooks are added even if detection fails Fixes the issue where users without ccmate hooks (new installations, manual deletions, or config migrations) could not receive notifications even though the notification settings UI was functional.
Owner
|
have you tested it? |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Related Issue
Fixes #26
Problem
The notification feature UI was displayed but did not work for users without ccmate hooks configured in
~/.claude/settings.json.Root Cause:
The startup logic only called
update_claude_code_hook(), which updates existing hooks but never adds them if missing.Solution
This PR adds intelligent hook initialization:
Changes Made
New Function (
src-tauri/src/commands.rs)check_claude_code_hooks_exist()to detect if ccmate hooks are present in Claude settingsUpdated Startup Logic (
src-tauri/src/lib.rs)Code Quality
pnpm tsc --noEmit)Impact
Users without ccmate hooks (new installations, manual deletions, config migrations) will now automatically get hooks configured on first launch, making notifications work immediately.