Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Issue for Django 1.6 in django_pgjson 0.3.0 #28

Open
themaxxx opened this issue Jul 4, 2015 · 3 comments
Open

Possible Issue for Django 1.6 in django_pgjson 0.3.0 #28

themaxxx opened this issue Jul 4, 2015 · 3 comments
Labels

Comments

@themaxxx
Copy link
Contributor

themaxxx commented Jul 4, 2015

Hi,

in fields.py there is this import

"from django.utils.module_loading import import_string"

but in Django 1.6 import_string is not present.

My current solution is :
if django.get_version() >= "1.7":
from django.utils.module_loading import import_string
else:
from django.utils.module_loading import import_by_path as import_string

Please let me know your opinion. Thx a lot.

@niwinz
Copy link
Member

niwinz commented Jul 5, 2015

Yeah, seems clearly a compatibility bug. If that solution works as expected, it is ok for me. PR is welcome ;)

@niwinz niwinz added the bug label Jul 5, 2015
@themaxxx
Copy link
Contributor Author

themaxxx commented Jul 8, 2015

Hi,
I forked the project and fixed the compatibility bug in case you want to pull it into the project repository.

Thanks!

@sibartlett
Copy link

Yeah, I'm getting this error too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants