Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI bug] Irrelevant Space In Home Page #1842

Open
SrisailamKakurala opened this issue Dec 21, 2024 · 5 comments · May be fixed by #1843
Open

[UI bug] Irrelevant Space In Home Page #1842

SrisailamKakurala opened this issue Dec 21, 2024 · 5 comments · May be fixed by #1843

Comments

@SrisailamKakurala
Copy link

DemoCreatorRec_2024-12-21.19-55-54.mp4

Description:
unnecessary space below join the community section.
and the containers of forum and discord are too small for the section which makes the UI a bit ugly.

Expected Behavior:
There should be no extra space and the containers[links] should be a little big and also they should have a hover effect to it's secondary color

Steps to Reproduce:

  1. go to https://www.djangoproject.com/
  2. scroll down to "join the community" section

Suggested Solution:

  1. remove the extra space
  2. add a hover effect to links
  3. could also add a few more links if necessary
SrisailamKakurala added a commit to SrisailamKakurala/djangoproject.com that referenced this issue Dec 21, 2024
@SrisailamKakurala
fixes django#1842
1e2fbc0
SrisailamKakurala added a commit to SrisailamKakurala/djangoproject.com that referenced this issue Dec 21, 2024
@SrisailamKakurala
fixes django#1842
bd2f94d
SrisailamKakurala added a commit to SrisailamKakurala/djangoproject.com that referenced this issue Dec 21, 2024
@SrisailamKakurala
fixes django#1842
401d5b8
@SrisailamKakurala SrisailamKakurala linked a pull request Dec 21, 2024 that will close this issue
Open
@SrisailamKakurala
Copy link
Author

@alex @jezdez @matthiask @justinabrahms can u please review the pr.

@alex
Copy link
Member

alex commented Dec 21, 2024

Do not spam random people. It is incredible rude.

@SrisailamKakurala
Copy link
Author

sorry!! i'm new to open source and this is my first contribution. so i thought u guys were repo managers. pardon me alex.
hope we'll get along.

SrisailamKakurala added a commit to SrisailamKakurala/djangoproject.com that referenced this issue Dec 21, 2024
@SrisailamKakurala
fixes django#1842
0781995
@adamzap
Copy link
Member

adamzap commented Dec 21, 2024

@SrisailamKakurala Are you saying that it's a problem that the sidebar content is adding vertical space to the layout more than the main content?

@SrisailamKakurala
Copy link
Author

SrisailamKakurala commented Dec 21, 2024 •
edited
Loading

@adamzap The side bar spacing is perfect but in the main layout i.e. below join the community section ... There's an additional vertical space which is occupied by a svg declaration.... Which is not being rendered there... So I changed its display to none ... Resulting in the elimination of space it took .... (See the code changes in #1843)

The svg is just a declaration for the theme icons that are used in the navbar.
So we can just hide it to eliminate space.
And also I added a hover effect to the links to join the community section.

@bmispelon bmispelon mentioned this issue Dec 28, 2024
Open
SrisailamKakurala added a commit to SrisailamKakurala/djangoproject.com that referenced this issue Dec 28, 2024
@SrisailamKakurala
pruned django#1842
4ff8933
SrisailamKakurala added a commit to SrisailamKakurala/djangoproject.com that referenced this issue Dec 28, 2024
@SrisailamKakurala
pruned django#1842 from django#1844
9a1f189
SrisailamKakurala added a commit to SrisailamKakurala/djangoproject.com that referenced this issue Dec 29, 2024
@SrisailamKakurala
pruned django#1842 from django#1844
332f321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alex @adamzap @SrisailamKakurala