Add a select few more styles to buttons

[ckohen]

Description

Since #3022 was closed (with good reason in my opinion), I propose this option instead. A select few additional button styles that use preexisting branding.

Why This is Needed

Currently developers have 5 choices for buttons, realistically 4. These are great, especially when doing something that the style is designed for.

The current styles names clearly state what they should do, but they can't quite cover all use cases.

For example say I wanted two "Neutral" buttons but with different importance. I would personally use grey for both of them as it is currently, but an additional few style choices would make it much easier to differentiate. Furthermore, there is already a precedent in-app for buttons that could potentially expose or lose lots of user data to have a different style.

Alternatives Considered

Continue using the existing styling (which does indeed work great for many cases)

Additional Details

Here are a couple options that would be ideal (any one or more of these would vastly increase flexibility):

Outlined red with red text (Danger):

White (Seems to be specific to Nitro currently, I anticipate Non-Blurple text being a better option however):

Opposite Theme (White for dark mode, Grey for light mode), sort of requires white to be added as well.

Opposite Theme Outline with opposite theme text:

Branding Yellow and/or Fuchsia (Neutral). Does not exist anywhere in app yet.

Blurple outline (not really sure about this one, but saw it in app so here it is):

[ckohen]

As it turns out, there are actually a few white buttons in app already, updated the comment for that.

[RedDaedalus]

Discord is moving away from outline buttons as they're bad for accessibility. The white button with blurple text could have its uses though.

[dynamo-codes]

I think custom colors would be the best but since discord won't do that for branding this is the next best thing

[8auu]

custom colors please!

[dutchman-dev]

They won't do that because of the style property of buttons.

[TheKing-OfTime]

In fact, now only two button styles are available to developers. This is a standard (style: 1, 2, 3, 4) that differ only in color. And the second is the link button. It seems to me that it would be more reasonable to make two styles and allow developers to choose colors in a separate parameter. But you can also do it with pre-prepared colors (for example: 1-blurple, 2-gray, 3-green, 4-red, etc.)
This change, for example, will allow developers to easily change the color of the link button without adding a bunch of duplicate styles

[actuallyhoss]

Discord branding's Yellow can be used as "Warning", and the Fuchsia can be used as "Info".
It would just give us more space to get creative with what we could do with buttons.

[typpo]

Greetings, everyone. We just spent a bunch of time going through button possibilities and decided we are not going to add more button styles. In general, we think button styles should be tied to behavior, not the color itself. For example, green to indicate success, red to indicate danger, etc. We also want to ensure that the styles we add to our public API reflect the best practices that we use in the client (outline buttons, for example, can raise accessibility issues).

So despite button colors being potentially exciting to devs, we haven't come across compelling semantic reasons to add more within the app. We thought about warning buttons in particular but in nearly all cases we think "danger" semantics suffice.

[ckohen]

Yeah, coming back to this now, I really only wanted another secondary button style as the primary feels so different.

Anyways, most of that desire I have realized could definitely be satisfied by future components

[WolfTM]

To be honest. This is just were the discord platform sinks in for me.. Limitations all the time on bot features.
You guys keep saying "WE" but like. Yes you guys want that. And we want this. So come up with a better midway solution.
What is wrong with a yellow warning style? Nothing. You can't compare yellow to red come on...
That is just a problem. Discord releases new features but always have big limitations to them...

(This is my opinion)

[mrhaubrich]

Why don't use HEX colors and change it directly in css? You could use parameters to set style like: border color, background color, text color. I don't think that limit a developer option in something like this is any good, everyone wants that, so why not?
And last, but not least:
"green to indicate success, red to indicate danger" this is horrible color choice if you want to talk about accessibility, since I know people with Protanopia, which is a colorblind type that can't differ between green and red, so I have to avoid using both in my code.
This is the first time I come to a github discussion to say anything, but i'm really disappointed with this "final answer" that sounds just like an excuse.
Have a great day, guys.

[MinnDevelopment]

this is horrible color choice if you want to talk about accessibility

Yes, but this is something that a colorblind mode can handle, while custom colors would be far more challenging. So you kind of made an argument against custom colors with this. You are not choosing colors, you are choosing button styles (which can be represented differently by clients, depending on settings) unlike custom colors.

[mrhaubrich]

You are not choosing colors, you are choosing button styles

If you can set border color and background separately you are changing what you call "button styles", since the only difference between styles is background color and the type(success, destructive???, etc), nothing more.

but this is something that a colorblind mode can handle

Since Discord don't care about creating this mode, it doesn't change a thing to be challenging or not, you have to install something to change colorblind modes directly in your device, so if it isn't a change made by Discord API, then, why would they bother to block me of using purple buttons, for instance? I think it's an excessive protection against a not very clear problem (that I think it doesn't exists). Custom colors won't change a thing in the app.

[DEVTomatoCake]

Just leaving this here - you can configure the accent color on your servers "Promo" page (seems to be a new unreleased feature but is publicly visible).

("Buttonvorschau" = Button preview)

While it's a different team developing this features, it's another thing which makes the a11y point seem invalid.
We don't need at all of them, but having all of them wouldn't hurt and prevents users from asking "I can have this button color on my server page, so why not in your bot?"

[TwilightZebby]

"Promo" page (seems to be a new unreleased feature but is publicly visible).

Promo Pages are released, for Servers with the ability to setup Server Subscriptions. Support Article linked here

That button shows on said Promo Page on Discord's Web-based Server Discovery, should said Server have a Promo Page enabled. See example Promo Page. The Button colour setting isn't used in-app afaik.

So my guess is that the website has different internal policies than their actual, official, clients/apps for these things?